diff mbox series

[BlueZ,v3,1/4] build: Fix manpage enable flag

Message ID 20210504050207.841261-2-hj.tedd.an@gmail.com (mailing list archive)
State Accepted
Delegated to: Luiz Von Dentz
Headers show
Series Convert manpages to rst format | expand

Commit Message

Tedd Ho-Jeong An May 4, 2021, 5:02 a.m. UTC
From: Tedd Ho-Jeong An <tedd.an@intel.com>

This patch fixes the manpages installation with --enable-manpages option
so the manpages are not installed by default if the option is not set
during the configuration.
---
 Makefile.am    | 19 ++++++++-----------
 Makefile.tools | 33 ++++++++++++++++++++-------------
 2 files changed, 28 insertions(+), 24 deletions(-)

Comments

bluez.test.bot@gmail.com May 4, 2021, 5:41 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=476657

---Test result---

Test Summary:
CheckPatch                    FAIL      1.19 seconds
GitLint                       PASS      0.49 seconds
Prep - Setup ELL              PASS      46.57 seconds
Build - Prep                  PASS      0.10 seconds
Build - Configure             PASS      7.98 seconds
Build - Make                  FAIL      195.74 seconds
Make Check                    FAIL      0.65 seconds
Make Dist                     PASS      12.38 seconds
Make Dist - Configure         PASS      4.97 seconds
Make Dist - Make              PASS      79.32 seconds
Build w/ext ELL - Configure   PASS      8.11 seconds
Build w/ext ELL - Make        FAIL      184.19 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
monitor: Convert manpage to rst format
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#125: FILE: monitor/btmon.rst:1:
+=====

- total: 0 errors, 1 warnings, 224 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] monitor: Convert manpage to rst format" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

tools: Convert manpages to rst format
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#111: FILE: tools/bdaddr.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#252: FILE: tools/btattach.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#411: FILE: tools/ciptool.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#652: FILE: tools/hciattach.rst:1:
+=========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1102: FILE: tools/hciconfig.rst:1:
+=========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1503: FILE: tools/hcidump.rst:1:
+=======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1889: FILE: tools/hcitool.rst:1:
+=======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2160: FILE: tools/hid2hci.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2298: FILE: tools/l2ping.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2469: FILE: tools/rctest.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2675: FILE: tools/rfcomm.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2919: FILE: tools/sdptool.rst:1:
+=======

- total: 0 errors, 12 warnings, 1414 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] tools: Convert manpages to rst format" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
monitor/btmon.rst:151: (WARNING/2) Cannot analyze code. Pygments package not found.
Exiting due to level-2 (WARNING) system message.
make[1]: *** [Makefile:11711: monitor/btmon.1] Error 1
make: *** [Makefile:4083: all] Error 2


##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
monitor/btmon.rst:151: (WARNING/2) Cannot analyze code. Pygments package not found.
Exiting due to level-2 (WARNING) system message.
make[1]: *** [Makefile:11711: monitor/btmon.1] Error 1
make: *** [Makefile:10353: check] Error 2


##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball

##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball

##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
monitor/btmon.rst:151: (WARNING/2) Cannot analyze code. Pygments package not found.
Exiting due to level-2 (WARNING) system message.
make[1]: *** [Makefile:11711: monitor/btmon.1] Error 1
make: *** [Makefile:4083: all] Error 2




---
Regards,
Linux Bluetooth
bluez.test.bot@gmail.com May 4, 2021, 7:39 a.m. UTC | #2
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=476657

---Test result---

Test Summary:
CheckPatch                    FAIL      1.29 seconds
GitLint                       PASS      0.46 seconds
Prep - Setup ELL              PASS      47.22 seconds
Build - Prep                  PASS      0.13 seconds
Build - Configure             PASS      8.57 seconds
Build - Make                  FAIL      200.01 seconds
Make Check                    FAIL      0.61 seconds
Make Dist                     PASS      11.75 seconds
Make Dist - Configure         PASS      5.09 seconds
Make Dist - Make              PASS      82.63 seconds
Build w/ext ELL - Configure   PASS      8.37 seconds
Build w/ext ELL - Make        FAIL      185.55 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
monitor: Convert manpage to rst format
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#125: FILE: monitor/btmon.rst:1:
+=====

- total: 0 errors, 1 warnings, 224 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] monitor: Convert manpage to rst format" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

tools: Convert manpages to rst format
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#111: FILE: tools/bdaddr.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#252: FILE: tools/btattach.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#411: FILE: tools/ciptool.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#652: FILE: tools/hciattach.rst:1:
+=========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1102: FILE: tools/hciconfig.rst:1:
+=========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1503: FILE: tools/hcidump.rst:1:
+=======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1889: FILE: tools/hcitool.rst:1:
+=======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2160: FILE: tools/hid2hci.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2298: FILE: tools/l2ping.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2469: FILE: tools/rctest.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2675: FILE: tools/rfcomm.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2919: FILE: tools/sdptool.rst:1:
+=======

- total: 0 errors, 12 warnings, 1414 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] tools: Convert manpages to rst format" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
monitor/btmon.rst:151: (WARNING/2) Cannot analyze code. Pygments package not found.
Exiting due to level-2 (WARNING) system message.
make[1]: *** [Makefile:11711: monitor/btmon.1] Error 1
make: *** [Makefile:4083: all] Error 2


##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
monitor/btmon.rst:151: (WARNING/2) Cannot analyze code. Pygments package not found.
Exiting due to level-2 (WARNING) system message.
make[1]: *** [Makefile:11711: monitor/btmon.1] Error 1
make: *** [Makefile:10353: check] Error 2


##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball

##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball

##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
monitor/btmon.rst:151: (WARNING/2) Cannot analyze code. Pygments package not found.
Exiting due to level-2 (WARNING) system message.
make[1]: *** [Makefile:11711: monitor/btmon.1] Error 1
make: *** [Makefile:4083: all] Error 2




---
Regards,
Linux Bluetooth
bluez.test.bot@gmail.com May 4, 2021, 8:44 a.m. UTC | #3
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=476657

---Test result---

Test Summary:
CheckPatch                    FAIL      1.09 seconds
GitLint                       PASS      0.49 seconds
Prep - Setup ELL              PASS      48.06 seconds
Build - Prep                  PASS      0.11 seconds
Build - Configure             PASS      8.27 seconds
Build - Make                  PASS      205.97 seconds
Make Check                    PASS      9.56 seconds
Make Dist                     PASS      13.28 seconds
Make Dist - Configure         PASS      5.14 seconds
Make Dist - Make              PASS      82.48 seconds
Build w/ext ELL - Configure   PASS      8.44 seconds
Build w/ext ELL - Make        PASS      191.12 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
monitor: Convert manpage to rst format
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#125: FILE: monitor/btmon.rst:1:
+=====

- total: 0 errors, 1 warnings, 224 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] monitor: Convert manpage to rst format" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

tools: Convert manpages to rst format
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#111: FILE: tools/bdaddr.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#252: FILE: tools/btattach.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#411: FILE: tools/ciptool.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#652: FILE: tools/hciattach.rst:1:
+=========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1102: FILE: tools/hciconfig.rst:1:
+=========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1503: FILE: tools/hcidump.rst:1:
+=======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1889: FILE: tools/hcitool.rst:1:
+=======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2160: FILE: tools/hid2hci.rst:1:
+========

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2298: FILE: tools/l2ping.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2469: FILE: tools/rctest.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2675: FILE: tools/rfcomm.rst:1:
+======

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2919: FILE: tools/sdptool.rst:1:
+=======

- total: 0 errors, 12 warnings, 1414 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] tools: Convert manpages to rst format" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball

##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball

##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth
Tedd Ho-Jeong An May 4, 2021, 4:07 p.m. UTC | #4
Hi

On Tue, 2021-05-04 at 01:44 -0700, bluez.test.bot@gmail.com wrote:
> This is automated email and please do not reply to this email!
> 
> Dear submitter,
> 
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=476657
> 
> ---Test result---
> 
> Test Summary:
> CheckPatch                    FAIL      1.09 seconds
> GitLint                       PASS      0.49 seconds
> Prep - Setup ELL              PASS      48.06 seconds
> Build - Prep                  PASS      0.11 seconds
> Build - Configure             PASS      8.27 seconds
> Build - Make                  PASS      205.97 seconds
> Make Check                    PASS      9.56 seconds
> Make Dist                     PASS      13.28 seconds
> Make Dist - Configure         PASS      5.14 seconds
> Make Dist - Make              PASS      82.48 seconds
> Build w/ext ELL - Configure   PASS      8.44 seconds
> Build w/ext ELL - Make        PASS      191.12 seconds
> 
> Details
> ##############################
> Test: CheckPatch - FAIL
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
> Output:
> monitor: Convert manpage to rst format
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #125: FILE: monitor/btmon.rst:1:
> +=====
> 
> - total: 0 errors, 1 warnings, 224 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> "[PATCH] monitor: Convert manpage to rst format" has style problems, please review.
> 
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> tools: Convert manpages to rst format
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #111: FILE: tools/bdaddr.rst:1:
> +======
> 
These errors can be ignored since no SPDX header is needed in the manpage file. Also
even if the SPDX license header is added, the checkpatch cannot parse .rst file and
still shows a warning.

> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #252: FILE: tools/btattach.rst:1:
> +========
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #411: FILE: tools/ciptool.rst:1:
> +========
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #652: FILE: tools/hciattach.rst:1:
> +=========
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #1102: FILE: tools/hciconfig.rst:1:
> +=========
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #1503: FILE: tools/hcidump.rst:1:
> +=======
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #1889: FILE: tools/hcitool.rst:1:
> +=======
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #2160: FILE: tools/hid2hci.rst:1:
> +========
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #2298: FILE: tools/l2ping.rst:1:
> +======
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #2469: FILE: tools/rctest.rst:1:
> +======
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #2675: FILE: tools/rfcomm.rst:1:
> +======
> 
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #2919: FILE: tools/sdptool.rst:1:
> +=======
> 
> - total: 0 errors, 12 warnings, 1414 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> "[PATCH] tools: Convert manpages to rst format" has style problems, please review.
> 
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> 
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
> 
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
> 
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
> 
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
> 
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
> 
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
> 
> ##############################
> Test: Make Dist - PASS
> Desc: Run 'make dist' and build the distribution tarball
> 
> ##############################
> Test: Make Dist - Configure - PASS
> Desc: Configure the source from distribution tarball
> 
> ##############################
> Test: Make Dist - Make - PASS
> Desc: Build the source from distribution tarball
> 
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
> 
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
> 
> 
> 
> ---
> Regards,
> Linux Bluetooth
> 

Regards,
Tedd
Luiz Augusto von Dentz May 4, 2021, 6:58 p.m. UTC | #5
Hi Tedd,

On Tue, May 4, 2021 at 11:25 AM Tedd Ho-Jeong An <hj.tedd.an@gmail.com> wrote:
>
> Hi
>
> On Tue, 2021-05-04 at 01:44 -0700, bluez.test.bot@gmail.com wrote:
> > This is automated email and please do not reply to this email!
> >
> > Dear submitter,
> >
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > This is a CI test results with your patch series:
> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=476657
> >
> > ---Test result---
> >
> > Test Summary:
> > CheckPatch                    FAIL      1.09 seconds
> > GitLint                       PASS      0.49 seconds
> > Prep - Setup ELL              PASS      48.06 seconds
> > Build - Prep                  PASS      0.11 seconds
> > Build - Configure             PASS      8.27 seconds
> > Build - Make                  PASS      205.97 seconds
> > Make Check                    PASS      9.56 seconds
> > Make Dist                     PASS      13.28 seconds
> > Make Dist - Configure         PASS      5.14 seconds
> > Make Dist - Make              PASS      82.48 seconds
> > Build w/ext ELL - Configure   PASS      8.44 seconds
> > Build w/ext ELL - Make        PASS      191.12 seconds
> >
> > Details
> > ##############################
> > Test: CheckPatch - FAIL
> > Desc: Run checkpatch.pl script with rule in .checkpatch.conf
> > Output:
> > monitor: Convert manpage to rst format
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #125: FILE: monitor/btmon.rst:1:
> > +=====
> >
> > - total: 0 errors, 1 warnings, 224 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> >       mechanically convert to the typical style using --fix or --fix-inplace.
> >
> > "[PATCH] monitor: Convert manpage to rst format" has style problems, please review.
> >
> > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
> >
> > NOTE: If any of the errors are false positives, please report
> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> >
> > tools: Convert manpages to rst format
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #111: FILE: tools/bdaddr.rst:1:
> > +======
> >
> These errors can be ignored since no SPDX header is needed in the manpage file. Also
> even if the SPDX license header is added, the checkpatch cannot parse .rst file and
> still shows a warning.

Isn't there a way to make checkpatch ignore those then? I can apply
them either way but going forward it would be great to avoid having
these errors.

> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #252: FILE: tools/btattach.rst:1:
> > +========
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #411: FILE: tools/ciptool.rst:1:
> > +========
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #652: FILE: tools/hciattach.rst:1:
> > +=========
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #1102: FILE: tools/hciconfig.rst:1:
> > +=========
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #1503: FILE: tools/hcidump.rst:1:
> > +=======
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #1889: FILE: tools/hcitool.rst:1:
> > +=======
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #2160: FILE: tools/hid2hci.rst:1:
> > +========
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #2298: FILE: tools/l2ping.rst:1:
> > +======
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #2469: FILE: tools/rctest.rst:1:
> > +======
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #2675: FILE: tools/rfcomm.rst:1:
> > +======
> >
> > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > #2919: FILE: tools/sdptool.rst:1:
> > +=======
> >
> > - total: 0 errors, 12 warnings, 1414 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> >       mechanically convert to the typical style using --fix or --fix-inplace.
> >
> > "[PATCH] tools: Convert manpages to rst format" has style problems, please review.
> >
> > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
> >
> > NOTE: If any of the errors are false positives, please report
> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> >
> >
> > ##############################
> > Test: GitLint - PASS
> > Desc: Run gitlint with rule in .gitlint
> >
> > ##############################
> > Test: Prep - Setup ELL - PASS
> > Desc: Clone, build, and install ELL
> >
> > ##############################
> > Test: Build - Prep - PASS
> > Desc: Prepare environment for build
> >
> > ##############################
> > Test: Build - Configure - PASS
> > Desc: Configure the BlueZ source tree
> >
> > ##############################
> > Test: Build - Make - PASS
> > Desc: Build the BlueZ source tree
> >
> > ##############################
> > Test: Make Check - PASS
> > Desc: Run 'make check'
> >
> > ##############################
> > Test: Make Dist - PASS
> > Desc: Run 'make dist' and build the distribution tarball
> >
> > ##############################
> > Test: Make Dist - Configure - PASS
> > Desc: Configure the source from distribution tarball
> >
> > ##############################
> > Test: Make Dist - Make - PASS
> > Desc: Build the source from distribution tarball
> >
> > ##############################
> > Test: Build w/ext ELL - Configure - PASS
> > Desc: Configure BlueZ source with '--enable-external-ell' configuration
> >
> > ##############################
> > Test: Build w/ext ELL - Make - PASS
> > Desc: Build BlueZ source with '--enable-external-ell' configuration
> >
> >
> >
> > ---
> > Regards,
> > Linux Bluetooth
> >
>
> Regards,
> Tedd
>
Tedd Ho-Jeong An May 4, 2021, 7:06 p.m. UTC | #6
On Tue, 2021-05-04 at 11:58 -0700, Luiz Augusto von Dentz wrote:
> Hi Tedd,
> 
> On Tue, May 4, 2021 at 11:25 AM Tedd Ho-Jeong An <hj.tedd.an@gmail.com> wrote:
> > Hi
> > 
> > On Tue, 2021-05-04 at 01:44 -0700, bluez.test.bot@gmail.com wrote:
> > > This is automated email and please do not reply to this email!
> > > 
> > > Dear submitter,
> > > 
> > > Thank you for submitting the patches to the linux bluetooth mailing list.
> > > This is a CI test results with your patch series:
> > > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=476657
> > > 
> > > ---Test result---
> > > 
> > > Test Summary:
> > > CheckPatch                    FAIL      1.09 seconds
> > > GitLint                       PASS      0.49 seconds
> > > Prep - Setup ELL              PASS      48.06 seconds
> > > Build - Prep                  PASS      0.11 seconds
> > > Build - Configure             PASS      8.27 seconds
> > > Build - Make                  PASS      205.97 seconds
> > > Make Check                    PASS      9.56 seconds
> > > Make Dist                     PASS      13.28 seconds
> > > Make Dist - Configure         PASS      5.14 seconds
> > > Make Dist - Make              PASS      82.48 seconds
> > > Build w/ext ELL - Configure   PASS      8.44 seconds
> > > Build w/ext ELL - Make        PASS      191.12 seconds
> > > 
> > > Details
> > > ##############################
> > > Test: CheckPatch - FAIL
> > > Desc: Run checkpatch.pl script with rule in .checkpatch.conf
> > > Output:
> > > monitor: Convert manpage to rst format
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #125: FILE: monitor/btmon.rst:1:
> > > +=====
> > > 
> > > - total: 0 errors, 1 warnings, 224 lines checked
> > > 
> > > NOTE: For some of the reported defects, checkpatch may be able to
> > >       mechanically convert to the typical style using --fix or --fix-inplace.
> > > 
> > > "[PATCH] monitor: Convert manpage to rst format" has style problems, please review.
> > > 
> > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
> > > 
> > > NOTE: If any of the errors are false positives, please report
> > >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > > 
> > > tools: Convert manpages to rst format
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #111: FILE: tools/bdaddr.rst:1:
> > > +======
> > > 
> > These errors can be ignored since no SPDX header is needed in the manpage file. Also
> > even if the SPDX license header is added, the checkpatch cannot parse .rst file and
> > still shows a warning.
> 
> Isn't there a way to make checkpatch ignore those then? I can apply
> them either way but going forward it would be great to avoid having
> these errors.
> 

Yes, there is a flag SPDX_LICENSE_TAG to turn off this check.
I will turn this off this then.

> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #252: FILE: tools/btattach.rst:1:
> > > +========
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #411: FILE: tools/ciptool.rst:1:
> > > +========
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #652: FILE: tools/hciattach.rst:1:
> > > +=========
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #1102: FILE: tools/hciconfig.rst:1:
> > > +=========
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #1503: FILE: tools/hcidump.rst:1:
> > > +=======
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #1889: FILE: tools/hcitool.rst:1:
> > > +=======
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #2160: FILE: tools/hid2hci.rst:1:
> > > +========
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #2298: FILE: tools/l2ping.rst:1:
> > > +======
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #2469: FILE: tools/rctest.rst:1:
> > > +======
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #2675: FILE: tools/rfcomm.rst:1:
> > > +======
> > > 
> > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> > > #2919: FILE: tools/sdptool.rst:1:
> > > +=======
> > > 
> > > - total: 0 errors, 12 warnings, 1414 lines checked
> > > 
> > > NOTE: For some of the reported defects, checkpatch may be able to
> > >       mechanically convert to the typical style using --fix or --fix-inplace.
> > > 
> > > "[PATCH] tools: Convert manpages to rst format" has style problems, please review.
> > > 
> > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
> > > 
> > > NOTE: If any of the errors are false positives, please report
> > >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > > 
> > > 
> > > ##############################
> > > Test: GitLint - PASS
> > > Desc: Run gitlint with rule in .gitlint
> > > 
> > > ##############################
> > > Test: Prep - Setup ELL - PASS
> > > Desc: Clone, build, and install ELL
> > > 
> > > ##############################
> > > Test: Build - Prep - PASS
> > > Desc: Prepare environment for build
> > > 
> > > ##############################
> > > Test: Build - Configure - PASS
> > > Desc: Configure the BlueZ source tree
> > > 
> > > ##############################
> > > Test: Build - Make - PASS
> > > Desc: Build the BlueZ source tree
> > > 
> > > ##############################
> > > Test: Make Check - PASS
> > > Desc: Run 'make check'
> > > 
> > > ##############################
> > > Test: Make Dist - PASS
> > > Desc: Run 'make dist' and build the distribution tarball
> > > 
> > > ##############################
> > > Test: Make Dist - Configure - PASS
> > > Desc: Configure the source from distribution tarball
> > > 
> > > ##############################
> > > Test: Make Dist - Make - PASS
> > > Desc: Build the source from distribution tarball
> > > 
> > > ##############################
> > > Test: Build w/ext ELL - Configure - PASS
> > > Desc: Configure BlueZ source with '--enable-external-ell' configuration
> > > 
> > > ##############################
> > > Test: Build w/ext ELL - Make - PASS
> > > Desc: Build BlueZ source with '--enable-external-ell' configuration
> > > 
> > > 
> > > 
> > > ---
> > > Regards,
> > > Linux Bluetooth
> > > 
> > 
> > Regards,
> > Tedd
> > 
> 
>
diff mbox series

Patch

diff --git a/Makefile.am b/Makefile.am
index 2a222167f..cb0d5fc0a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -12,10 +12,6 @@  bin_PROGRAMS =
 
 noinst_PROGRAMS =
 
-dist_man_MANS =
-
-dist_noinst_MANS =
-
 CLEANFILES =
 
 EXTRA_DIST =
@@ -60,6 +56,10 @@  else
 build_plugindir = $(plugindir)
 endif
 
+if MANPAGES
+man_MANS =
+endif
+manual_pages =
 
 plugin_LTLIBRARIES =
 
@@ -342,7 +342,10 @@  nodist_src_bluetoothd_SOURCES = $(builtin_files)
 
 CLEANFILES += $(builtin_files) src/bluetooth.service
 
-man_MANS = src/bluetoothd.8
+if MANPAGES
+man_MANS += src/bluetoothd.8
+endif
+EXTRA_DIST += src/bluetoothd.8
 
 EXTRA_DIST += src/genbuiltin src/bluetooth.conf \
 			src/main.conf profiles/network/network.conf \
@@ -591,12 +594,6 @@  if LIBRARY
 pkgconfig_DATA = lib/bluez.pc
 endif
 
-manual_pages = doc/btmon.1
-
-if MANPAGES
-dist_noinst_MANS += $(manual_pages)
-endif
-
 EXTRA_DIST += $(manual_pages:.1=.txt)
 
 DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles --enable-library \
diff --git a/Makefile.tools b/Makefile.tools
index 57e858290..160272212 100644
--- a/Makefile.tools
+++ b/Makefile.tools
@@ -49,7 +49,12 @@  monitor_btmon_SOURCES = monitor/main.c monitor/bt.h \
 				monitor/tty.h
 monitor_btmon_LDADD = lib/libbluetooth-internal.la \
 				src/libshared-mainloop.la $(UDEV_LIBS) -ldl
+
+if MANPAGES
+man_MANS += doc/btmon.1
+endif
 endif
+manual_pages += doc/btmon.1
 
 if LOGGER
 pkglibexec_PROGRAMS += tools/btmon-logger
@@ -292,9 +297,9 @@  tools_gatt_service_LDADD = $(GLIB_LIBS) $(DBUS_LIBS) gdbus/libgdbus-internal.la
 profiles_iap_iapd_SOURCES = profiles/iap/main.c
 profiles_iap_iapd_LDADD = gdbus/libgdbus-internal.la $(GLIB_LIBS) $(DBUS_LIBS)
 
-dist_man_MANS += tools/rctest.1 tools/l2ping.1 tools/btattach.1
-
-EXTRA_DIST += tools/bdaddr.1
+if MANPAGES
+man_MANS += tools/rctest.1 tools/l2ping.1 tools/btattach.1
+endif
 
 if MESH
 bin_PROGRAMS += tools/meshctl
@@ -400,17 +405,18 @@  tools_hcidump_LDADD = lib/libbluetooth-internal.la
 
 tools_rfcomm_LDADD = lib/libbluetooth-internal.la
 
-dist_man_MANS += tools/hciattach.1 tools/hciconfig.1 \
-			tools/hcitool.1 tools/hcidump.1 \
-			tools/rfcomm.1 tools/sdptool.1 tools/ciptool.1
-else
-EXTRA_DIST += tools/hciattach.1 tools/hciconfig.1 \
+if MANPAGES
+man_MANS += tools/hciattach.1 tools/hciconfig.1 \
 			tools/hcitool.1 tools/hcidump.1 \
 			tools/rfcomm.1 tools/sdptool.1 tools/ciptool.1
 endif
-else
-EXTRA_DIST += tools/rctest.1 tools/l2ping.1 tools/btattach.1
 endif
+endif
+EXTRA_DIST += tools/hciattach.1 tools/hciconfig.1 \
+			tools/hcitool.1 tools/hcidump.1 \
+			tools/rfcomm.1 tools/sdptool.1 tools/ciptool.1 \
+			tools/rctest.1 tools/l2ping.1 tools/btattach.1 \
+			tools/bdaddr.1
 
 if HID2HCI
 udevdir = $(UDEV_DIR)
@@ -419,10 +425,11 @@  udev_PROGRAMS = tools/hid2hci
 
 tools_hid2hci_LDADD = $(UDEV_LIBS)
 
-dist_man_MANS += tools/hid2hci.1
-else
-EXTRA_DIST += tools/hid2hci.1
+if MANPAGES
+man_MANS += tools/hid2hci.1
+endif
 endif
+EXTRA_DIST += tools/hid2hci.1
 
 if READLINE
 noinst_PROGRAMS += tools/btmgmt tools/obex-client-tool tools/obex-server-tool \