| Message ID | 20210329132632.68901-1-mreitz@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iotests/297: Cover tests/ | expand |
Am 29.03.2021 um 15:26 hat Max Reitz geschrieben: > Hi, > > When reviewing Vladimir’s new addition to tests/, I noticed that 297 so > far does not cover named tests. That isn’t so good. > > This series makes it cover them, and because tests/ is rather sparse at > this point, I decided to also fix up the two tests in there that don’t > pass pylint’s scrutiny yet. I think it would be nice if we could keep > all of tests/ clean. For patch 2, Vladimir already made the point I would have made. For the rest: Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Hi! Kindly remind. Didn't you forget? I'm responsible for these two tests, let me know if you don't have time, and I'll resend this series :) 29.03.2021 16:26, Max Reitz wrote: > Hi, > > When reviewing Vladimir’s new addition to tests/, I noticed that 297 so > far does not cover named tests. That isn’t so good. > > This series makes it cover them, and because tests/ is rather sparse at > this point, I decided to also fix up the two tests in there that don’t > pass pylint’s scrutiny yet. I think it would be nice if we could keep > all of tests/ clean. > > > Max Reitz (4): > iotests/297: Drop 169 and 199 from the skip list > migrate-bitmaps-postcopy-test: Fix pylint warnings > migrate-bitmaps-test: Fix pylint warnings > iotests/297: Cover tests/ > > tests/qemu-iotests/297 | 7 ++-- > .../tests/migrate-bitmaps-postcopy-test | 3 ++ > tests/qemu-iotests/tests/migrate-bitmaps-test | 38 ++++++++++--------- > 3 files changed, 27 insertions(+), 21 deletions(-) >
On 05.05.21 10:02, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > Kindly remind. Didn't you forget? I'm responsible for these two tests, > let me know if you don't have time, and I'll resend this series :) Sorry, I forgot indeed... v2 coming right up. :) Max