diff mbox series

usb: dwc3: remove repeated setting of current_dr_role

Message ID 20210506072608.32320-1-chunfeng.yun@mediatek.com (mailing list archive)
State Accepted
Commit 374ac7448caa73d689b50fd3c4fb59e40f1ab0b1
Headers show
Series usb: dwc3: remove repeated setting of current_dr_role | expand

Commit Message

Chunfeng Yun May 6, 2021, 7:26 a.m. UTC 
dwc3_set_prtcap() already sets current_dr_role as
DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/dwc3/drd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Felipe Balbi May 6, 2021, 8:54 a.m. UTC | #1 
Hi,

Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> dwc3_set_prtcap() already sets current_dr_role as
> DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

looks correct to me:

Acked-by: Felipe Balbi <balbi@kernel.org>
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index e2b68bb770d1..8fcbac10510c 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -596,7 +596,6 @@  int dwc3_drd_init(struct dwc3 *dwc)
 		dwc3_drd_update(dwc);
 	} else {
 		dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
-		dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
 
 		/* use OTG block to get ID event */
 		irq = dwc3_otg_get_irq(dwc);