| Message ID | 20210507060142.17049-1-sergio.paracuellos@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: ralink: phy-mt7621-pci: properly print pointer address | expand |
On Fri, May 07, 2021 at 08:01:42AM +0200, Sergio Paracuellos wrote: > The way of printing the pointer address for the 'port_base' > address got into compile warnings on some architectures > [-Wpointer-to-int-cast]. Instead of use '%08x' and cast > to an 'unsigned int' just make use of '%px' and avoid the > cast. > > Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > --- > drivers/phy/ralink/phy-mt7621-pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c > index 753cb5bab930..4705931fb072 100644 > --- a/drivers/phy/ralink/phy-mt7621-pci.c > +++ b/drivers/phy/ralink/phy-mt7621-pci.c > @@ -272,8 +272,8 @@ static struct phy *mt7621_pcie_phy_of_xlate(struct device *dev, > > mt7621_phy->has_dual_port = args->args[0]; > > - dev_info(dev, "PHY for 0x%08x (dual port = %d)\n", > - (unsigned int)mt7621_phy->port_base, mt7621_phy->has_dual_port); > + dev_info(dev, "PHY for 0x%px (dual port = %d)\n", > + mt7621_phy->port_base, mt7621_phy->has_dual_port); This whole message should be dropped as drivers should be quiet if all is going well, and only print messages when things go wrong. And why cc: linux-staging? thanks, greg k-h
Hi, On Fri, May 7, 2021 at 8:27 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Fri, May 07, 2021 at 08:01:42AM +0200, Sergio Paracuellos wrote: > > The way of printing the pointer address for the 'port_base' > > address got into compile warnings on some architectures > > [-Wpointer-to-int-cast]. Instead of use '%08x' and cast > > to an 'unsigned int' just make use of '%px' and avoid the > > cast. > > > > Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > --- > > drivers/phy/ralink/phy-mt7621-pci.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c > > index 753cb5bab930..4705931fb072 100644 > > --- a/drivers/phy/ralink/phy-mt7621-pci.c > > +++ b/drivers/phy/ralink/phy-mt7621-pci.c > > @@ -272,8 +272,8 @@ static struct phy *mt7621_pcie_phy_of_xlate(struct device *dev, > > > > mt7621_phy->has_dual_port = args->args[0]; > > > > - dev_info(dev, "PHY for 0x%08x (dual port = %d)\n", > > - (unsigned int)mt7621_phy->port_base, mt7621_phy->has_dual_port); > > + dev_info(dev, "PHY for 0x%px (dual port = %d)\n", > > + mt7621_phy->port_base, mt7621_phy->has_dual_port); > > This whole message should be dropped as drivers should be quiet if all > is going well, and only print messages when things go wrong. Got it. Will move this into dev_dbg instead. Thanks. > > And why cc: linux-staging? True, sorry for that. Ctrl + r search for previous git send-mail and I forgot to drop staging from there. > > thanks, > > greg k-h Best regards, Sergio Paracuellos
diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c index 753cb5bab930..4705931fb072 100644 --- a/drivers/phy/ralink/phy-mt7621-pci.c +++ b/drivers/phy/ralink/phy-mt7621-pci.c @@ -272,8 +272,8 @@ static struct phy *mt7621_pcie_phy_of_xlate(struct device *dev, mt7621_phy->has_dual_port = args->args[0]; - dev_info(dev, "PHY for 0x%08x (dual port = %d)\n", - (unsigned int)mt7621_phy->port_base, mt7621_phy->has_dual_port); + dev_info(dev, "PHY for 0x%px (dual port = %d)\n", + mt7621_phy->port_base, mt7621_phy->has_dual_port); return mt7621_phy->phy; }
The way of printing the pointer address for the 'port_base' address got into compile warnings on some architectures [-Wpointer-to-int-cast]. Instead of use '%08x' and cast to an 'unsigned int' just make use of '%px' and avoid the cast. Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> --- drivers/phy/ralink/phy-mt7621-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)