diff mbox series

[13/42] PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts

Message ID 20210506153153.30454-14-pali@kernel.org (mailing list archive)
State New, archived
Headers show
Series PCI: aardvark: Various driver fixes | expand

Commit Message

Pali Rohár May 6, 2021, 3:31 p.m. UTC 
Callback for irq_mask_ack is the same as for irq_mask. As there is no
special handling for irq_ack, there is no need to define irq_mask_ack too.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <kabel@kernel.org>
---
 drivers/pci/controller/pci-aardvark.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Marc Zyngier May 7, 2021, 9:16 a.m. UTC | #1 
On Thu, 06 May 2021 16:31:24 +0100,
Pali Rohár <pali@kernel.org> wrote:
> 
> Callback for irq_mask_ack is the same as for irq_mask. As there is no
> special handling for irq_ack, there is no need to define irq_mask_ack too.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <kabel@kernel.org>
> ---
>  drivers/pci/controller/pci-aardvark.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
> index e7089db11f79..2aced8c9ae9f 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -1032,7 +1032,6 @@ static int advk_pcie_init_irq_domain(struct advk_pcie *pcie)
>  	}
>  
>  	irq_chip->irq_mask = advk_pcie_irq_mask;
> -	irq_chip->irq_mask_ack = advk_pcie_irq_mask;
>  	irq_chip->irq_unmask = advk_pcie_irq_unmask;
>  
>  	pcie->irq_domain =

Acked-by: Marc Zyngier <maz@kernel.org>

	M.
diff mbox series

Patch

diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index e7089db11f79..2aced8c9ae9f 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -1032,7 +1032,6 @@  static int advk_pcie_init_irq_domain(struct advk_pcie *pcie)
 	}
 
 	irq_chip->irq_mask = advk_pcie_irq_mask;
-	irq_chip->irq_mask_ack = advk_pcie_irq_mask;
 	irq_chip->irq_unmask = advk_pcie_irq_unmask;
 
 	pcie->irq_domain =