| Message ID | 20210506133145.2266604-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: bme680_spi: Remove ACPI support | expand |
Hi, On 5/6/21 3:31 PM, Guenter Roeck wrote: > BME0680 is not an official ACPI ID, so let's remove it before someone > starts using it. > > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/iio/chemical/bme680_spi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c > index 6f56ad48cc40..cc579a7ac5ce 100644 > --- a/drivers/iio/chemical/bme680_spi.c > +++ b/drivers/iio/chemical/bme680_spi.c > @@ -4,7 +4,6 @@ > * > * Copyright (C) 2018 Himanshu Jha <himanshujha199640@gmail.com> > */ > -#include <linux/acpi.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/regmap.h> > @@ -145,12 +144,6 @@ static const struct spi_device_id bme680_spi_id[] = { > }; > MODULE_DEVICE_TABLE(spi, bme680_spi_id); > > -static const struct acpi_device_id bme680_acpi_match[] = { > - {"BME0680", 0}, > - {}, > -}; > -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match); > - > static const struct of_device_id bme680_of_spi_match[] = { > { .compatible = "bosch,bme680", }, > {}, > @@ -160,7 +153,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_spi_match); > static struct spi_driver bme680_spi_driver = { > .driver = { > .name = "bme680_spi", > - .acpi_match_table = ACPI_PTR(bme680_acpi_match), > .of_match_table = bme680_of_spi_match, > }, > .probe = bme680_spi_probe, >
On Thu, May 6, 2021 at 4:31 PM Guenter Roeck <linux@roeck-us.net> wrote: > > BME0680 is not an official ACPI ID, so let's remove it before someone > starts using it. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/iio/chemical/bme680_spi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c > index 6f56ad48cc40..cc579a7ac5ce 100644 > --- a/drivers/iio/chemical/bme680_spi.c > +++ b/drivers/iio/chemical/bme680_spi.c > @@ -4,7 +4,6 @@ > * > * Copyright (C) 2018 Himanshu Jha <himanshujha199640@gmail.com> > */ > -#include <linux/acpi.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/regmap.h> > @@ -145,12 +144,6 @@ static const struct spi_device_id bme680_spi_id[] = { > }; > MODULE_DEVICE_TABLE(spi, bme680_spi_id); > > -static const struct acpi_device_id bme680_acpi_match[] = { > - {"BME0680", 0}, > - {}, > -}; > -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match); > - > static const struct of_device_id bme680_of_spi_match[] = { > { .compatible = "bosch,bme680", }, > {}, > @@ -160,7 +153,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_spi_match); > static struct spi_driver bme680_spi_driver = { > .driver = { > .name = "bme680_spi", > - .acpi_match_table = ACPI_PTR(bme680_acpi_match), > .of_match_table = bme680_of_spi_match, > }, > .probe = bme680_spi_probe, > -- > 2.25.1 >
On Thu, 6 May 2021 06:31:45 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > BME0680 is not an official ACPI ID, so let's remove it before someone > starts using it. > > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Applied with message tweaked for PRP0001 and title changed to make it clear this isn't removing ACPI support, just one means of doing it. Jonathan > --- > drivers/iio/chemical/bme680_spi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c > index 6f56ad48cc40..cc579a7ac5ce 100644 > --- a/drivers/iio/chemical/bme680_spi.c > +++ b/drivers/iio/chemical/bme680_spi.c > @@ -4,7 +4,6 @@ > * > * Copyright (C) 2018 Himanshu Jha <himanshujha199640@gmail.com> > */ > -#include <linux/acpi.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/regmap.h> > @@ -145,12 +144,6 @@ static const struct spi_device_id bme680_spi_id[] = { > }; > MODULE_DEVICE_TABLE(spi, bme680_spi_id); > > -static const struct acpi_device_id bme680_acpi_match[] = { > - {"BME0680", 0}, > - {}, > -}; > -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match); > - > static const struct of_device_id bme680_of_spi_match[] = { > { .compatible = "bosch,bme680", }, > {}, > @@ -160,7 +153,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_spi_match); > static struct spi_driver bme680_spi_driver = { > .driver = { > .name = "bme680_spi", > - .acpi_match_table = ACPI_PTR(bme680_acpi_match), > .of_match_table = bme680_of_spi_match, > }, > .probe = bme680_spi_probe,
diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c index 6f56ad48cc40..cc579a7ac5ce 100644 --- a/drivers/iio/chemical/bme680_spi.c +++ b/drivers/iio/chemical/bme680_spi.c @@ -4,7 +4,6 @@ * * Copyright (C) 2018 Himanshu Jha <himanshujha199640@gmail.com> */ -#include <linux/acpi.h> #include <linux/module.h> #include <linux/of.h> #include <linux/regmap.h> @@ -145,12 +144,6 @@ static const struct spi_device_id bme680_spi_id[] = { }; MODULE_DEVICE_TABLE(spi, bme680_spi_id); -static const struct acpi_device_id bme680_acpi_match[] = { - {"BME0680", 0}, - {}, -}; -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match); - static const struct of_device_id bme680_of_spi_match[] = { { .compatible = "bosch,bme680", }, {}, @@ -160,7 +153,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_spi_match); static struct spi_driver bme680_spi_driver = { .driver = { .name = "bme680_spi", - .acpi_match_table = ACPI_PTR(bme680_acpi_match), .of_match_table = bme680_of_spi_match, }, .probe = bme680_spi_probe,
BME0680 is not an official ACPI ID, so let's remove it before someone starts using it. Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/iio/chemical/bme680_spi.c | 8 -------- 1 file changed, 8 deletions(-)