| Message ID | 20210509113354.660190-8-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IIO: Runtime PM related cleanups. | expand |
Hi, On 5/9/21 1:33 PM, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > This driver alls pm_runtime_put_noidle() in it's remove function, but there > is no matching get call. This isn't a bug as runtime pm will not allow > the reference counter to go negative, but it is missleading so lets remove > it. > > Whilst here use pm_runtime_resume_and_get() to tidy up some boilerplate. > The coccicheck script didn't get this one due to the less obvious > structure. Found by inspection. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Hans de Goede <hdegoede@redhat.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/iio/accel/kxcjk-1013.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c > index 283e6a3feffc..a9e3dae43ac5 100644 > --- a/drivers/iio/accel/kxcjk-1013.c > +++ b/drivers/iio/accel/kxcjk-1013.c > @@ -478,7 +478,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) > int ret; > > if (on) > - ret = pm_runtime_get_sync(&data->client->dev); > + ret = pm_runtime_resume_and_get(&data->client->dev); > else { > pm_runtime_mark_last_busy(&data->client->dev); > ret = pm_runtime_put_autosuspend(&data->client->dev); > @@ -486,8 +486,6 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) > if (ret < 0) { > dev_err(&data->client->dev, > "Failed: %s for %d\n", __func__, on); > - if (on) > - pm_runtime_put_noidle(&data->client->dev); > return ret; > } > #endif > @@ -1485,7 +1483,6 @@ static int kxcjk1013_remove(struct i2c_client *client) > > pm_runtime_disable(&client->dev); > pm_runtime_set_suspended(&client->dev); > - pm_runtime_put_noidle(&client->dev); > > if (data->dready_trig) { > iio_triggered_buffer_cleanup(indio_dev); >
Em Sun, 9 May 2021 12:33:33 +0100 Jonathan Cameron <jic23@kernel.org> escreveu: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > This driver alls pm_runtime_put_noidle() in it's remove function, but there > is no matching get call. This isn't a bug as runtime pm will not allow > the reference counter to go negative, but it is missleading so lets remove > it. > > Whilst here use pm_runtime_resume_and_get() to tidy up some boilerplate. > The coccicheck script didn't get this one due to the less obvious > structure. Found by inspection. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Hans de Goede <hdegoede@redhat.com> LGTM. Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/iio/accel/kxcjk-1013.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c > index 283e6a3feffc..a9e3dae43ac5 100644 > --- a/drivers/iio/accel/kxcjk-1013.c > +++ b/drivers/iio/accel/kxcjk-1013.c > @@ -478,7 +478,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) > int ret; > > if (on) > - ret = pm_runtime_get_sync(&data->client->dev); > + ret = pm_runtime_resume_and_get(&data->client->dev); > else { > pm_runtime_mark_last_busy(&data->client->dev); > ret = pm_runtime_put_autosuspend(&data->client->dev); > @@ -486,8 +486,6 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) > if (ret < 0) { > dev_err(&data->client->dev, > "Failed: %s for %d\n", __func__, on); > - if (on) > - pm_runtime_put_noidle(&data->client->dev); > return ret; > } > #endif > @@ -1485,7 +1483,6 @@ static int kxcjk1013_remove(struct i2c_client *client) > > pm_runtime_disable(&client->dev); > pm_runtime_set_suspended(&client->dev); > - pm_runtime_put_noidle(&client->dev); > > if (data->dready_trig) { > iio_triggered_buffer_cleanup(indio_dev); Thanks, Mauro
diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index 283e6a3feffc..a9e3dae43ac5 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c @@ -478,7 +478,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) int ret; if (on) - ret = pm_runtime_get_sync(&data->client->dev); + ret = pm_runtime_resume_and_get(&data->client->dev); else { pm_runtime_mark_last_busy(&data->client->dev); ret = pm_runtime_put_autosuspend(&data->client->dev); @@ -486,8 +486,6 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) if (ret < 0) { dev_err(&data->client->dev, "Failed: %s for %d\n", __func__, on); - if (on) - pm_runtime_put_noidle(&data->client->dev); return ret; } #endif @@ -1485,7 +1483,6 @@ static int kxcjk1013_remove(struct i2c_client *client) pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); - pm_runtime_put_noidle(&client->dev); if (data->dready_trig) { iio_triggered_buffer_cleanup(indio_dev);