| Message ID | 20210503154712.508-1-olaf@aepfle.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] tools: add newlines to xenstored WRL_LOG | expand |
On 03.05.21 17:47, Olaf Hering wrote: > According to syslog(3) the fmt string does not need a newline. > The mini-os implementation of syslog requires the trailing newline. > Other calls to syslog do include the newline already, add it also to WRL_LOG. Mind doing the same for the two syslog() calls in xenstored_core.c lacking the newline? Juergen
Am Mon, 10 May 2021 09:31:41 +0200 schrieb Juergen Gross <jgross@suse.com>: > Mind doing the same for the two syslog() calls in xenstored_core.c > lacking the newline? I will send a separate patch for them. Olaf
On 10.05.21 10:34, Olaf Hering wrote: > Am Mon, 10 May 2021 09:31:41 +0200 > schrieb Juergen Gross <jgross@suse.com>: > >> Mind doing the same for the two syslog() calls in xenstored_core.c >> lacking the newline? > > I will send a separate patch for them. Okay, in this case you can add my Reviewed-by: Juergen Gross <jgross@suse.com> to the WRL_LOG patch. Juergen
diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 3d4d0649a2..2d333b3ff6 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1132,10 +1132,10 @@ void wrl_apply_debit_actual(struct domain *domain) if (domain->wrl_credit < 0) { if (!domain->wrl_delay_logged) { domain->wrl_delay_logged = true; - WRL_LOG(now, "domain %ld is affected", + WRL_LOG(now, "domain %ld is affected\n", (long)domain->domid); } else if (!wrl_log_last_warning) { - WRL_LOG(now, "rate limiting restarts"); + WRL_LOG(now, "rate limiting restarts\n"); } wrl_log_last_warning = now.sec; } @@ -1145,7 +1145,7 @@ void wrl_log_periodic(struct wrl_timestampt now) { if (wrl_log_last_warning && (now.sec - wrl_log_last_warning) > WRL_LOGEVERY) { - WRL_LOG(now, "not in force recently"); + WRL_LOG(now, "not in force recently\n"); wrl_log_last_warning = 0; } }
According to syslog(3) the fmt string does not need a newline. The mini-os implementation of syslog requires the trailing newline. Other calls to syslog do include the newline already, add it also to WRL_LOG. Signed-off-by: Olaf Hering <olaf@aepfle.de> --- tools/xenstore/xenstored_domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)