| Message ID | 20201012154709.68521-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] ARM: Drop ARCH_NR_GPIOS definition | expand |
On Mon, Oct 12, 2020 at 06:47:09PM +0300, Andy Shevchenko wrote: > The conditional by the generic header is the same, > hence drop unnecessary duplication. Any comment on this? > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/arm/include/asm/gpio.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h > index c50e383358c4..f3bb8a2bf788 100644 > --- a/arch/arm/include/asm/gpio.h > +++ b/arch/arm/include/asm/gpio.h > @@ -2,10 +2,6 @@ > #ifndef _ARCH_ARM_GPIO_H > #define _ARCH_ARM_GPIO_H > > -#if CONFIG_ARCH_NR_GPIO > 0 > -#define ARCH_NR_GPIOS CONFIG_ARCH_NR_GPIO > -#endif > - > /* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h */ > #include <asm-generic/gpio.h> > > -- > 2.28.0 >
On Mon, Oct 12, 2020 at 06:47:09PM +0300, Andy Shevchenko wrote: > The conditional by the generic header is the same, > hence drop unnecessary duplication. Can we get this proceed somehow? > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/arm/include/asm/gpio.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h > index c50e383358c4..f3bb8a2bf788 100644 > --- a/arch/arm/include/asm/gpio.h > +++ b/arch/arm/include/asm/gpio.h > @@ -2,10 +2,6 @@ > #ifndef _ARCH_ARM_GPIO_H > #define _ARCH_ARM_GPIO_H > > -#if CONFIG_ARCH_NR_GPIO > 0 > -#define ARCH_NR_GPIOS CONFIG_ARCH_NR_GPIO > -#endif > - > /* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h */ > #include <asm-generic/gpio.h> > > -- > 2.28.0 >
On Mon, Oct 12, 2020 at 06:47:09PM +0300, Andy Shevchenko wrote: > The conditional by the generic header is the same, > hence drop unnecessary duplication. Any comment on this anybody? > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/arm/include/asm/gpio.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h > index c50e383358c4..f3bb8a2bf788 100644 > --- a/arch/arm/include/asm/gpio.h > +++ b/arch/arm/include/asm/gpio.h > @@ -2,10 +2,6 @@ > #ifndef _ARCH_ARM_GPIO_H > #define _ARCH_ARM_GPIO_H > > -#if CONFIG_ARCH_NR_GPIO > 0 > -#define ARCH_NR_GPIOS CONFIG_ARCH_NR_GPIO > -#endif > - > /* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h */ > #include <asm-generic/gpio.h> > > -- > 2.28.0 >
On Wed, Feb 24, 2021 at 4:21 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Oct 12, 2020 at 06:47:09PM +0300, Andy Shevchenko wrote: > > The conditional by the generic header is the same, > > hence drop unnecessary duplication. > > Any comment on this anybody? +Cc: Linus and Arnd, maybe you can help to advance this to somewhere? > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > arch/arm/include/asm/gpio.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h > > index c50e383358c4..f3bb8a2bf788 100644 > > --- a/arch/arm/include/asm/gpio.h > > +++ b/arch/arm/include/asm/gpio.h > > @@ -2,10 +2,6 @@ > > #ifndef _ARCH_ARM_GPIO_H > > #define _ARCH_ARM_GPIO_H > > > > -#if CONFIG_ARCH_NR_GPIO > 0 > > -#define ARCH_NR_GPIOS CONFIG_ARCH_NR_GPIO > > -#endif > > - > > /* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h */ > > #include <asm-generic/gpio.h> > > > > -- > > 2.28.0 > > > > -- > With Best Regards, > Andy Shevchenko > >
Hi Andy, On Mon, Oct 12, 2020 at 5:47 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The conditional by the generic header is the same, > hence drop unnecessary duplication. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> sorry for extremely slow reply. I think we could merge this into the GPIO tree if Russell is OK with it, alternatively put it in Russell's patch tracker. It looks absolutely correct. Yours, Linus Walleij
On Tue, Mar 02, 2021 at 04:51:37PM +0100, Linus Walleij wrote: > Hi Andy, > > On Mon, Oct 12, 2020 at 5:47 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > The conditional by the generic header is the same, > > hence drop unnecessary duplication. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > sorry for extremely slow reply. > > I think we could merge this into the GPIO tree if Russell is OK with it, > alternatively put it in Russell's patch tracker. It looks absolutely correct. I have sent a v2 (same patch, just in case somebody lost this thread).
diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h index c50e383358c4..f3bb8a2bf788 100644 --- a/arch/arm/include/asm/gpio.h +++ b/arch/arm/include/asm/gpio.h @@ -2,10 +2,6 @@ #ifndef _ARCH_ARM_GPIO_H #define _ARCH_ARM_GPIO_H -#if CONFIG_ARCH_NR_GPIO > 0 -#define ARCH_NR_GPIOS CONFIG_ARCH_NR_GPIO -#endif - /* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h */ #include <asm-generic/gpio.h>
The conditional by the generic header is the same, hence drop unnecessary duplication. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/arm/include/asm/gpio.h | 4 ---- 1 file changed, 4 deletions(-)