| Message ID | 1620296105-121964-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | ib_srpt: Remove redundant assignment to ret | expand |
On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote: > Variable 'ret' is set to -ENOMEM but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed > > In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")' > srpt_queue_response() has been changed to return void, so after "goto > out", there is no need to return ret. > > Clean up the following clang-analyzer warning: > > drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to > 'ret' is never read [clang-analyzer-deadcode.DeadStores] > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - > 1 file changed, 1 deletion(-) > Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API") Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On 5/6/21 4:34 AM, Leon Romanovsky wrote: > On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote: >> Variable 'ret' is set to -ENOMEM but this value is never read as it is >> overwritten with a new value later on, hence it is a redundant >> assignment and can be removed >> >> In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")' >> srpt_queue_response() has been changed to return void, so after "goto >> out", there is no need to return ret. >> >> Clean up the following clang-analyzer warning: >> >> drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to >> 'ret' is never read [clang-analyzer-deadcode.DeadStores] >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >> --- >> drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - >> 1 file changed, 1 deletion(-) >> > > Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API") > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Reverting commit b99f8e4d7bcd and handling queue_*_rsp() errors in the LIO core probably would be a better approach. Anyway: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote: > Variable 'ret' is set to -ENOMEM but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed > > In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")' > srpt_queue_response() has been changed to return void, so after "goto > out", there is no need to return ret. > > Clean up the following clang-analyzer warning: > > drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to > 'ret' is never read [clang-analyzer-deadcode.DeadStores] > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > Reviewed-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - > 1 file changed, 1 deletion(-) Applied to for-next Thanks, Jason
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index ea44780..3cadf12 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2858,7 +2858,6 @@ static void srpt_queue_response(struct se_cmd *cmd) &ch->sq_wr_avail) < 0)) { pr_warn("%s: IB send queue full (needed %d)\n", __func__, ioctx->n_rdma); - ret = -ENOMEM; goto out; }
Variable 'ret' is set to -ENOMEM but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")' srpt_queue_response() has been changed to return void, so after "goto out", there is no need to return ret. Clean up the following clang-analyzer warning: drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores] Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-)