| Message ID | 20210511223425.12863-1-wenhui@gwmail.gwu.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) | expand |
wenhuizhang <wenhui@gwmail.gwu.edu> writes: > Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group). > > line 741 struct cifsInodeInfo *cinode; > line 747 cinode = CIFS_I(d_inode(cfile->dentry)); > could be deleted. > > cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required. > The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode. > > Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> That's better but: * the subject (first line of commit msg) should be about what the patch actually does, usally with a prefix of the subsystem. So for example: cifs: remove deadstore in cifs_close_all_deferred_files() * the body of the commit msg should be wrapped around 80 cols to avoid long lines unless you are quoting some output or urls Cheers,
diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index 524dbdfb7184..801a5300f765 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c @@ -738,13 +738,11 @@ void cifs_close_all_deferred_files(struct cifs_tcon *tcon) { struct cifsFileInfo *cfile; - struct cifsInodeInfo *cinode; struct list_head *tmp; spin_lock(&tcon->open_file_lock); list_for_each(tmp, &tcon->openFileList) { cfile = list_entry(tmp, struct cifsFileInfo, tlist); - cinode = CIFS_I(d_inode(cfile->dentry)); if (delayed_work_pending(&cfile->deferred)) mod_delayed_work(deferredclose_wq, &cfile->deferred, 0); }
Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group). line 741 struct cifsInodeInfo *cinode; line 747 cinode = CIFS_I(d_inode(cfile->dentry)); could be deleted. cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required. The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode. Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> --- fs/cifs/misc.c | 2 -- 1 file changed, 2 deletions(-)