| Message ID | 20210509113354.660190-17-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IIO: Runtime PM related cleanups. | expand |
On 5/9/21 1:33 PM, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > --- > drivers/iio/dac/stm32-dac.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Hi Jonathan, Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Thanks for the patch, Regards, Fabrice > > diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c > index a5b0a52bf86e..dd2e306824e7 100644 > --- a/drivers/iio/dac/stm32-dac.c > +++ b/drivers/iio/dac/stm32-dac.c > @@ -69,9 +69,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, > } > > if (enable) { > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > - pm_runtime_put_noidle(dev); > mutex_unlock(&dac->lock); > return ret; > } >
Em Sun, 9 May 2021 12:33:42 +0100 Jonathan Cameron <jic23@kernel.org> escreveu: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> LGTM. Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/iio/dac/stm32-dac.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c > index a5b0a52bf86e..dd2e306824e7 100644 > --- a/drivers/iio/dac/stm32-dac.c > +++ b/drivers/iio/dac/stm32-dac.c > @@ -69,9 +69,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, > } > > if (enable) { > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > - pm_runtime_put_noidle(dev); > mutex_unlock(&dac->lock); > return ret; > } Thanks, Mauro
On Wed, 12 May 2021 16:20:26 +0200 Mauro Carvalho Chehab <mchehab@kernel.org> wrote: > Em Sun, 9 May 2021 12:33:42 +0100 > Jonathan Cameron <jic23@kernel.org> escreveu: > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Found using coccicheck script under review at: > > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > > in general > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > > LGTM. > > Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Applied. Thanks Jonathan > > > --- > > drivers/iio/dac/stm32-dac.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c > > index a5b0a52bf86e..dd2e306824e7 100644 > > --- a/drivers/iio/dac/stm32-dac.c > > +++ b/drivers/iio/dac/stm32-dac.c > > @@ -69,9 +69,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, > > } > > > > if (enable) { > > - ret = pm_runtime_get_sync(dev); > > + ret = pm_runtime_resume_and_get(dev); > > if (ret < 0) { > > - pm_runtime_put_noidle(dev); > > mutex_unlock(&dac->lock); > > return ret; > > } > > > > Thanks, > Mauro
diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c index a5b0a52bf86e..dd2e306824e7 100644 --- a/drivers/iio/dac/stm32-dac.c +++ b/drivers/iio/dac/stm32-dac.c @@ -69,9 +69,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, } if (enable) { - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) { - pm_runtime_put_noidle(dev); mutex_unlock(&dac->lock); return ret; }