| Message ID | 20210509113354.660190-21-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IIO: Runtime PM related cleanups. | expand |
Em Sun, 9 May 2021 12:33:46 +0100 Jonathan Cameron <jic23@kernel.org> escreveu: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> LGTM. Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/iio/light/us5182d.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c > index 393f27b75c75..96e4a66ddf28 100644 > --- a/drivers/iio/light/us5182d.c > +++ b/drivers/iio/light/us5182d.c > @@ -367,9 +367,7 @@ static int us5182d_set_power_state(struct us5182d_data *data, bool on) > return 0; > > if (on) { > - ret = pm_runtime_get_sync(&data->client->dev); > - if (ret < 0) > - pm_runtime_put_noidle(&data->client->dev); > + ret = pm_runtime_resume_and_get(&data->client->dev); > } else { > pm_runtime_mark_last_busy(&data->client->dev); > ret = pm_runtime_put_autosuspend(&data->client->dev); Thanks, Mauro
On Wed, 12 May 2021 16:35:33 +0200 Mauro Carvalho Chehab <mchehab@kernel.org> wrote: > Em Sun, 9 May 2021 12:33:46 +0100 > Jonathan Cameron <jic23@kernel.org> escreveu: > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Found using coccicheck script under review at: > > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > > in general. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > LGTM. > > Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > Applied. Thanks, Jonathan > > > --- > > drivers/iio/light/us5182d.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c > > index 393f27b75c75..96e4a66ddf28 100644 > > --- a/drivers/iio/light/us5182d.c > > +++ b/drivers/iio/light/us5182d.c > > @@ -367,9 +367,7 @@ static int us5182d_set_power_state(struct us5182d_data *data, bool on) > > return 0; > > > > if (on) { > > - ret = pm_runtime_get_sync(&data->client->dev); > > - if (ret < 0) > > - pm_runtime_put_noidle(&data->client->dev); > > + ret = pm_runtime_resume_and_get(&data->client->dev); > > } else { > > pm_runtime_mark_last_busy(&data->client->dev); > > ret = pm_runtime_put_autosuspend(&data->client->dev); > > > > Thanks, > Mauro
diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c index 393f27b75c75..96e4a66ddf28 100644 --- a/drivers/iio/light/us5182d.c +++ b/drivers/iio/light/us5182d.c @@ -367,9 +367,7 @@ static int us5182d_set_power_state(struct us5182d_data *data, bool on) return 0; if (on) { - ret = pm_runtime_get_sync(&data->client->dev); - if (ret < 0) - pm_runtime_put_noidle(&data->client->dev); + ret = pm_runtime_resume_and_get(&data->client->dev); } else { pm_runtime_mark_last_busy(&data->client->dev); ret = pm_runtime_put_autosuspend(&data->client->dev);