| Message ID | 20210513193204.816681-3-davidgow@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Shuah Khan |
| Headers | show |
| Series | [v2,01/10] kunit: Do not typecheck binary assertions | expand |
On Thu, May 13, 2021 at 12:36 PM David Gow <davidgow@google.com> wrote: > > As the type checking is no longer excessively strict, get rid of the > unsightly (char*) casts -- and comment discussing them -- from the KUnit > usage page. > > Signed-off-by: David Gow <davidgow@google.com> Reviewed-by: Daniel Latypov <dlatypov@google.com> Thanks! > --- > Documentation/dev-tools/kunit/usage.rst | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst > index 650f99590df5..756747417a19 100644 > --- a/Documentation/dev-tools/kunit/usage.rst > +++ b/Documentation/dev-tools/kunit/usage.rst > @@ -465,10 +465,9 @@ fictitious example for ``sha1sum(1)`` > > .. code-block:: c > > - /* Note: the cast is to satisfy overly strict type-checking. */ > #define TEST_SHA1(in, want) \ > sha1sum(in, out); \ > - KUNIT_EXPECT_STREQ_MSG(test, (char *)out, want, "sha1sum(%s)", in); > + KUNIT_EXPECT_STREQ_MSG(test, out, want, "sha1sum(%s)", in); > > char out[40]; > TEST_SHA1("hello world", "2aae6c35c94fcfb415dbe95f408b9ce91ee846ed"); > @@ -507,7 +506,7 @@ In some cases, it can be helpful to write a *table-driven test* instead, e.g. > }; > for (i = 0; i < ARRAY_SIZE(cases); ++i) { > sha1sum(cases[i].str, out); > - KUNIT_EXPECT_STREQ_MSG(test, (char *)out, cases[i].sha1, > + KUNIT_EXPECT_STREQ_MSG(test, out, cases[i].sha1, > "sha1sum(%s)", cases[i].str); > } > > @@ -568,7 +567,7 @@ Reusing the same ``cases`` array from above, we can write the test as a > struct sha1_test_case *test_param = (struct sha1_test_case *)(test->param_value); > > sha1sum(test_param->str, out); > - KUNIT_EXPECT_STREQ_MSG(test, (char *)out, test_param->sha1, > + KUNIT_EXPECT_STREQ_MSG(test, out, test_param->sha1, > "sha1sum(%s)", test_param->str); > } > > -- > 2.31.1.751.gd2f1c929bd-goog >
On Thu, May 13, 2021 at 12:36 PM David Gow <davidgow@google.com> wrote: > > As the type checking is no longer excessively strict, get rid of the > unsightly (char*) casts -- and comment discussing them -- from the KUnit > usage page. > > Signed-off-by: David Gow <davidgow@google.com> Acked-by: Brendan Higgins <brendanhiggins@google.com>
diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst index 650f99590df5..756747417a19 100644 --- a/Documentation/dev-tools/kunit/usage.rst +++ b/Documentation/dev-tools/kunit/usage.rst @@ -465,10 +465,9 @@ fictitious example for ``sha1sum(1)`` .. code-block:: c - /* Note: the cast is to satisfy overly strict type-checking. */ #define TEST_SHA1(in, want) \ sha1sum(in, out); \ - KUNIT_EXPECT_STREQ_MSG(test, (char *)out, want, "sha1sum(%s)", in); + KUNIT_EXPECT_STREQ_MSG(test, out, want, "sha1sum(%s)", in); char out[40]; TEST_SHA1("hello world", "2aae6c35c94fcfb415dbe95f408b9ce91ee846ed"); @@ -507,7 +506,7 @@ In some cases, it can be helpful to write a *table-driven test* instead, e.g. }; for (i = 0; i < ARRAY_SIZE(cases); ++i) { sha1sum(cases[i].str, out); - KUNIT_EXPECT_STREQ_MSG(test, (char *)out, cases[i].sha1, + KUNIT_EXPECT_STREQ_MSG(test, out, cases[i].sha1, "sha1sum(%s)", cases[i].str); } @@ -568,7 +567,7 @@ Reusing the same ``cases`` array from above, we can write the test as a struct sha1_test_case *test_param = (struct sha1_test_case *)(test->param_value); sha1sum(test_param->str, out); - KUNIT_EXPECT_STREQ_MSG(test, (char *)out, test_param->sha1, + KUNIT_EXPECT_STREQ_MSG(test, out, test_param->sha1, "sha1sum(%s)", test_param->str); }
As the type checking is no longer excessively strict, get rid of the unsightly (char*) casts -- and comment discussing them -- from the KUnit usage page. Signed-off-by: David Gow <davidgow@google.com> --- Documentation/dev-tools/kunit/usage.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)