| Message ID | 20210514122825.162203-1-y.karadz@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | libtraceevent: Better warning print-out | expand |
On Fri, 14 May 2021 15:28:25 +0300 "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > I see no new line when the messages are printed from KernelShark. > > Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> > --- > src/trace-seq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/trace-seq.c b/src/trace-seq.c > index 8d5ecd2..6aee07a 100644 > --- a/src/trace-seq.c > +++ b/src/trace-seq.c > @@ -22,7 +22,7 @@ > #define TRACE_SEQ_CHECK(s) \ > do { \ > if (WARN_ONCE((s)->buffer == TRACE_SEQ_POISON, \ > - "Usage of trace_seq after it was destroyed")) \ > + "Usage of trace_seq after it was destroyed\n")) \ > (s)->state = TRACE_SEQ__BUFFER_POISONED; \ > } while (0) > > @@ -85,7 +85,7 @@ static void expand_buffer(struct trace_seq *s) > char *buf; > > buf = realloc(s->buffer, s->buffer_size + TRACE_SEQ_BUF_SIZE); > - if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory")) { > + if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory\n")) { > s->state = TRACE_SEQ__MEM_ALLOC_FAILED; > return; > } This comes from the Linux kernel which doesn't require the message to contain a new line. Would this patch work instead? diff --git a/include/asm/bug.h b/include/asm/bug.h index 550223f..de8f8fe 100644 --- a/include/asm/bug.h +++ b/include/asm/bug.h @@ -5,7 +5,7 @@ #include <linux/compiler.h> #include <stdio.h> -#define __WARN_printf(arg...) do { fprintf(stderr, arg); } while (0) +#define __WARN_printf(arg...) do { fprintf(stderr, arg); fprintf(stderr, "\n");} while (0) #define WARN(condition, format...) ({ \ int __ret_warn_on = !!(condition); \
diff --git a/src/trace-seq.c b/src/trace-seq.c index 8d5ecd2..6aee07a 100644 --- a/src/trace-seq.c +++ b/src/trace-seq.c @@ -22,7 +22,7 @@ #define TRACE_SEQ_CHECK(s) \ do { \ if (WARN_ONCE((s)->buffer == TRACE_SEQ_POISON, \ - "Usage of trace_seq after it was destroyed")) \ + "Usage of trace_seq after it was destroyed\n")) \ (s)->state = TRACE_SEQ__BUFFER_POISONED; \ } while (0) @@ -85,7 +85,7 @@ static void expand_buffer(struct trace_seq *s) char *buf; buf = realloc(s->buffer, s->buffer_size + TRACE_SEQ_BUF_SIZE); - if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory")) { + if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory\n")) { s->state = TRACE_SEQ__MEM_ALLOC_FAILED; return; }
I see no new line when the messages are printed from KernelShark. Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> --- src/trace-seq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)