diff mbox

[trivial] input: apanel: remove a redundant MODULE_ALIAS

Message ID 1314653189-31020-1-git-send-email-j.neuschaefer@gmx.net (mailing list archive)
State New, archived
Headers show

Commit Message

J. Neuschäfer Aug. 29, 2011, 9:26 p.m. UTC
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 drivers/input/misc/apanel.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Dave Jones Aug. 29, 2011, 10 p.m. UTC | #1
On Mon, Aug 29, 2011 at 11:26:29PM +0200, Jonathan Neuschäfer wrote:
 
 > -MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*");
 >  MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*");
 
                                         ^
Is the module matching code case-insensitive ?

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov Aug. 29, 2011, 10:07 p.m. UTC | #2
On Monday, August 29, 2011 02:26:29 PM Jonathan Neuschäfer wrote:
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  drivers/input/misc/apanel.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c
> index a8d2b8d..1dd1bd3 100644
> --- a/drivers/input/misc/apanel.c
> +++ b/drivers/input/misc/apanel.c
> @@ -346,5 +346,4 @@ MODULE_DESCRIPTION(APANEL_NAME " driver");
>  MODULE_LICENSE("GPL");
>  MODULE_VERSION(APANEL_VERSION);
> 
> -MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*");
>  MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*");
                                        ^

Not necessarily redundant, if you notice the register is different.
Stephen Hemminger Aug. 29, 2011, 11:10 p.m. UTC | #3
On Mon, 29 Aug 2011 15:07:14 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Monday, August 29, 2011 02:26:29 PM Jonathan Neuschäfer wrote:
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> >  drivers/input/misc/apanel.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c
> > index a8d2b8d..1dd1bd3 100644
> > --- a/drivers/input/misc/apanel.c
> > +++ b/drivers/input/misc/apanel.c
> > @@ -346,5 +346,4 @@ MODULE_DESCRIPTION(APANEL_NAME " driver");
> >  MODULE_LICENSE("GPL");
> >  MODULE_VERSION(APANEL_VERSION);
> > 
> > -MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*");
> >  MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*");
>                                         ^
> 
> Not necessarily redundant, if you notice the register is different.
> 

At one point I found machines with both values, that is why there
are two entries.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
J. Neuschäfer Aug. 30, 2011, 5:14 p.m. UTC | #4
On Mon, Aug 29, 2011 at 04:10:15PM -0700, Stephen Hemminger wrote:
> On Mon, 29 Aug 2011 15:07:14 -0700
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> 
> > On Monday, August 29, 2011 02:26:29 PM Jonathan Neuschäfer wrote:
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > > ---
> > >  drivers/input/misc/apanel.c |    1 -
> > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c
> > > index a8d2b8d..1dd1bd3 100644
> > > --- a/drivers/input/misc/apanel.c
> > > +++ b/drivers/input/misc/apanel.c
> > > @@ -346,5 +346,4 @@ MODULE_DESCRIPTION(APANEL_NAME " driver");
> > >  MODULE_LICENSE("GPL");
> > >  MODULE_VERSION(APANEL_VERSION);
> > > 
> > > -MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*");
> > >  MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*");
> >                                         ^
> > 
> > Not necessarily redundant, if you notice the register is different.
> > 
> 
> At one point I found machines with both values, that is why there
> are two entries.

Okay, I didn't see the difference, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c
index a8d2b8d..1dd1bd3 100644
--- a/drivers/input/misc/apanel.c
+++ b/drivers/input/misc/apanel.c
@@ -346,5 +346,4 @@  MODULE_DESCRIPTION(APANEL_NAME " driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(APANEL_VERSION);
 
-MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*");
 MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*");