| Message ID | 20210514220942.879805-1-arnd@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | asm-generic: strncpy_from_user/strnlen_user cleanup | expand |
I generall like this consolidation, but for the patches that remote the arch / asm-generic versions, can you please elaborate a little more why the lib version is preferable? The current commit logs are not very informative.
On Sat, May 15, 2021 at 8:40 AM Christoph Hellwig <hch@lst.de> wrote: > > I generall like this consolidation, but for the patches that remote > the arch / asm-generic versions, can you please elaborate a little > more why the lib version is preferable? The current commit logs are > not very informative. Indeed. I do remember writing the patches last year thinking "this should really get fixed", but apparently I failed to describe the actual problem at the time. I have gone through it again and annotated what I found now, but I have a feeling that there were additional problems with the old code that I still did not capture. Sending v2 now: same code, more text. Arnd
From: Arnd Bergmann <arnd@arndb.de> As I've queued up some patches for include/asm-generic/unistd.h, I remembered an older series that I created but never submitted. These two functions appear to be unnecessarily different between architectures, and the asm-generic version is a bit questionable, even for NOMMU architectures. Clean this up to just use the generic library version for anything that uses the generic version today. Arnd Arnd Bergmann (5): asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user hexagon: use generic strncpy/strnlen from_user arc: use generic strncpy/strnlen from_user asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user asm-generic: remove extra strn{cpy_from,len}_user declarations arch/arc/Kconfig | 2 + arch/arc/include/asm/uaccess.h | 72 ---------------- arch/arc/mm/extable.c | 12 --- arch/h8300/Kconfig | 2 + arch/hexagon/Kconfig | 2 + arch/hexagon/include/asm/uaccess.h | 31 ------- arch/hexagon/kernel/hexagon_ksyms.c | 1 - arch/hexagon/mm/Makefile | 2 +- arch/hexagon/mm/strnlen_user.S | 126 ---------------------------- arch/m68k/Kconfig | 4 +- arch/riscv/Kconfig | 4 +- arch/um/include/asm/uaccess.h | 5 +- arch/um/kernel/skas/uaccess.c | 5 +- include/asm-generic/uaccess.h | 52 ++---------- 14 files changed, 24 insertions(+), 296 deletions(-) delete mode 100644 arch/hexagon/mm/strnlen_user.S