diff mbox series

[4/4] arm64: head: fix code comments in set_cpu_boot_mode_flag

Message ID 20210518101405.1048860-5-aisheng.dong@nxp.com (mailing list archive)
State New, archived
Headers show
Series arm64: mm: a few small cleanups | expand

Commit Message

Aisheng Dong May 18, 2021, 10:14 a.m. UTC
Up to here, the CPU boot mode can either be EL1 or EL2.
Correct the code comments a bit.

Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 arch/arm64/kernel/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Rutland May 18, 2021, 12:13 p.m. UTC | #1
On Tue, May 18, 2021 at 06:14:05PM +0800, Dong Aisheng wrote:
> Up to here, the CPU boot mode can either be EL1 or EL2.
> Correct the code comments a bit.
> 
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/kernel/head.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
> index d266b4c6287d..3b88000841d9 100644
> --- a/arch/arm64/kernel/head.S
> +++ b/arch/arm64/kernel/head.S
> @@ -550,7 +550,7 @@ SYM_FUNC_START_LOCAL(set_cpu_boot_mode_flag)
>  	cmp	w0, #BOOT_CPU_MODE_EL2
>  	b.ne	1f
>  	add	x1, x1, #4
> -1:	str	w0, [x1]			// This CPU has booted in EL1
> +1:	str	w0, [x1]			// Save CPU boot mode
>  	dmb	sy
>  	dc	ivac, x1			// Invalidate potentially stale cache line
>  	ret
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Catalin Marinas June 15, 2021, 1:31 p.m. UTC | #2
On Tue, May 18, 2021 at 06:14:05PM +0800, Dong Aisheng wrote:
> Up to here, the CPU boot mode can either be EL1 or EL2.
> Correct the code comments a bit.
> 
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

And cc'ing Will.
diff mbox series

Patch

diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
index d266b4c6287d..3b88000841d9 100644
--- a/arch/arm64/kernel/head.S
+++ b/arch/arm64/kernel/head.S
@@ -550,7 +550,7 @@  SYM_FUNC_START_LOCAL(set_cpu_boot_mode_flag)
 	cmp	w0, #BOOT_CPU_MODE_EL2
 	b.ne	1f
 	add	x1, x1, #4
-1:	str	w0, [x1]			// This CPU has booted in EL1
+1:	str	w0, [x1]			// Save CPU boot mode
 	dmb	sy
 	dc	ivac, x1			// Invalidate potentially stale cache line
 	ret