| Message ID | 20210518095647.3008-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | staging: iio: cdc: ad7746: Remove unnecessary assignment in ad7746_probe() | expand |
On Tue, May 18, 2021 at 05:56:47PM +0800, Tang Bin wrote: > In the function ad7746_probe(), the initialized value of 'ret' is unused, > because it will be assigned by the function i2c_smbus_write_byte_data(), > thus remove it. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Thanks! Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> regards, dan carpenter
On Tue, 18 May 2021 13:16:26 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Tue, May 18, 2021 at 05:56:47PM +0800, Tang Bin wrote: > > In the function ad7746_probe(), the initialized value of 'ret' is unused, > > because it will be assigned by the function i2c_smbus_write_byte_data(), > > thus remove it. > > > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > Thanks! > > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> > > regards, > dan carpenter > As this doesn't (I think) overlap with Lucas' series I've applied this one to the togreg branch of iio.git and pushed it out as testing for the autobuilders to see if we missed anything.
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index dfd71e99e..be4ef454d 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -680,7 +680,7 @@ static int ad7746_probe(struct i2c_client *client, struct ad7746_chip_info *chip; struct iio_dev *indio_dev; unsigned char regval = 0; - int ret = 0; + int ret; indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip)); if (!indio_dev)
In the function ad7746_probe(), the initialized value of 'ret' is unused, because it will be assigned by the function i2c_smbus_write_byte_data(), thus remove it. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/staging/iio/cdc/ad7746.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)