diff mbox series

BTF: build failure on 32bit on linux-next

Message ID 20210521162041.GH8544@kitsune.suse.cz (mailing list archive)
State Not Applicable
Delegated to: BPF
Headers show
Series BTF: build failure on 32bit on linux-next | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Michal Suchanek May 21, 2021, 4:20 p.m. UTC 
Hello,

looks like the TODO prints added in 67234743736a6 are not 32bit clean.

Do you plan to implement this functionality or should they be fixed?

Thanks

Michal

Comments

Andrii Nakryiko May 22, 2021, 12:46 a.m. UTC | #1 
On Fri, May 21, 2021 at 9:20 AM Michal Suchánek <msuchanek@suse.de> wrote:
>
> Hello,
>
> looks like the TODO prints added in 67234743736a6 are not 32bit clean.
>
> Do you plan to implement this functionality or should they be fixed?

They should be fixed regardless. Can you please re-submit as a proper
patch to bpf@vger.kernel.org with [PATCH bpf-next] subj prefix?

>
> Thanks
>
> Michal
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 69cd1a835ebd..70a26af8d01f 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -4565,7 +4565,7 @@ static int init_map_slots(struct bpf_object *obj, struct bpf_map *map)
>                 targ_map = map->init_slots[i];
>                 fd = bpf_map__fd(targ_map);
>                 if (obj->gen_loader) {
> -                       pr_warn("// TODO map_update_elem: idx %ld key %d value==map_idx %ld\n",
> +                       pr_warn("// TODO map_update_elem: idx %td key %d value==map_idx %td\n",
>                                 map - obj->maps, i, targ_map - obj->maps);
>                         return -ENOTSUP;
>                 } else {
> @@ -6189,7 +6189,7 @@ static int bpf_core_apply_relo(struct bpf_program *prog,
>                 return -EINVAL;
>
>         if (prog->obj->gen_loader) {
> -               pr_warn("// TODO core_relo: prog %ld insn[%d] %s %s kind %d\n",
> +               pr_warn("// TODO core_relo: prog %td insn[%d] %s %s kind %d\n",
>                         prog - prog->obj->programs, relo->insn_off / 8,
>                         local_name, spec_str, relo->kind);
>                 return -ENOTSUP;
diff mbox series

Patch

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 69cd1a835ebd..70a26af8d01f 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -4565,7 +4565,7 @@  static int init_map_slots(struct bpf_object *obj, struct bpf_map *map)
 		targ_map = map->init_slots[i];
 		fd = bpf_map__fd(targ_map);
 		if (obj->gen_loader) {
-			pr_warn("// TODO map_update_elem: idx %ld key %d value==map_idx %ld\n",
+			pr_warn("// TODO map_update_elem: idx %td key %d value==map_idx %td\n",
 				map - obj->maps, i, targ_map - obj->maps);
 			return -ENOTSUP;
 		} else {
@@ -6189,7 +6189,7 @@  static int bpf_core_apply_relo(struct bpf_program *prog,
 		return -EINVAL;
 
 	if (prog->obj->gen_loader) {
-		pr_warn("// TODO core_relo: prog %ld insn[%d] %s %s kind %d\n",
+		pr_warn("// TODO core_relo: prog %td insn[%d] %s %s kind %d\n",
 			prog - prog->obj->programs, relo->insn_off / 8,
 			local_name, spec_str, relo->kind);
 		return -ENOTSUP;