[v7,0/6] clk: provide new devm helpers for prepared and enabled clocks

Message

Uwe Kleine-König May 10, 2021, 5:41 p.m. UTC

Hello,

compared to v6 I rebased to v5.13-rc1 (which resulted in a conflict in
the pwm-atmel patch), reformated the doc comments in patch 2 (as
suggested by Jonathan Cameron) and added the two Reviewed-by tags for
Jonathan Cameron.

Best regards
Uwe

Uwe Kleine-König (6):
  clk: generalize devm_clk_get() a bit
  clk: Provide new devm_clk_helpers for prepared and enabled clocks
  pwm: atmel: Simplify using devm_clk_get_prepared()
  rtc: at91sam9: Simplify using devm_clk_get_enabled()
  i2c: imx: Simplify using devm_clk_get_enabled()
  spi: davinci: Simplify using devm_clk_get_enabled()

 drivers/clk/clk-devres.c     | 96 ++++++++++++++++++++++++++++++------
 drivers/i2c/busses/i2c-imx.c | 12 +----
 drivers/pwm/pwm-atmel.c      | 15 +-----
 drivers/rtc/rtc-at91sam9.c   | 22 ++-------
 drivers/spi/spi-davinci.c    | 11 +----
 include/linux/clk.h          | 90 ++++++++++++++++++++++++++++++++-
 6 files changed, 179 insertions(+), 67 deletions(-)


base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5

Comments

Alexandru Ardelean May 11, 2021, 7:58 a.m. UTC | #1

On Mon, 10 May 2021 at 20:41, Uwe Kleine-König
<[e-mail]> wrote:
>
> Hello,
>
> compared to v6 I rebased to v5.13-rc1 (which resulted in a conflict in
> the pwm-atmel patch), reformated the doc comments in patch 2 (as
> suggested by Jonathan Cameron) and added the two Reviewed-by tags for
> Jonathan Cameron.

This will definitely cleanup a lot of boiler-plate code for probe()/remove().
What I'm noticing, is that some remove hooks [in the drivers in this
series] are being slightly re-ordered;
i.e. the clk_disable/unprepare may happen in a slightly different
order, but it doesn't look like those would be problematic.

So, for the series:
Reviewed-by: Alexandru Ardelean <[e-mail]>

Thanks
Alex

>
> Best regards
> Uwe
>
> Uwe Kleine-König (6):
>   clk: generalize devm_clk_get() a bit
>   clk: Provide new devm_clk_helpers for prepared and enabled clocks
>   pwm: atmel: Simplify using devm_clk_get_prepared()
>   rtc: at91sam9: Simplify using devm_clk_get_enabled()
>   i2c: imx: Simplify using devm_clk_get_enabled()
>   spi: davinci: Simplify using devm_clk_get_enabled()
>
>  drivers/clk/clk-devres.c     | 96 ++++++++++++++++++++++++++++++------
>  drivers/i2c/busses/i2c-imx.c | 12 +----
>  drivers/pwm/pwm-atmel.c      | 15 +-----
>  drivers/rtc/rtc-at91sam9.c   | 22 ++-------
>  drivers/spi/spi-davinci.c    | 11 +----
>  include/linux/clk.h          | 90 ++++++++++++++++++++++++++++++++-
>  6 files changed, 179 insertions(+), 67 deletions(-)
>
>
> base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
> --
> 2.30.2
>

Uwe Kleine-König May 24, 2021, 11:09 a.m. UTC | #2

On Mon, May 10, 2021 at 07:41:36PM +0200, Uwe Kleine-König wrote:
> compared to v6 I rebased to v5.13-rc1 (which resulted in a conflict in
> the pwm-atmel patch), reformated the doc comments in patch 2 (as
> suggested by Jonathan Cameron) and added the two Reviewed-by tags for
> Jonathan Cameron.

Another two weeks without maintainer feedback. I didn't find a single
mail by either Michael Turquette nor by Stephen Boyd on the linux-clk
list on lore dating from this month. This patch set didn't get a reply
since more than half a year.

Is the clk tree still maintained?  Would a pull request help? There are
several people who expressed interest in this series and the cleanup it
allows.

@Andrew: Would you be willing to take the first two patches if Michael
and Stephen don't react in the near future?

Best regards
Uwe