| Message ID | 1620220479-2647-2-git-send-email-alain.volmat@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i2c: stm32f7: add SMBus-Alert support | expand |
On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote: > Since SMBus-Alert is an optional feature of SMBUS which > requires an additional pin, the smbus binding cannot be > used to indicate its support. > > Add an additional smbus-alert binding specific for it and > update the description text of smbus to avoid mentioning > SMBus-Alert > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) This needs to be added to i2c-bus.yaml too. Acked-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt > index df41f72afc87..b864916e087f 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt > @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings. > > - smbus > states that additional SMBus restrictions and features apply to this bus. > - Examples of features are SMBusHostNotify and SMBusAlert. Examples of > - restrictions are more reserved addresses and timeout definitions. > + An example of feature is SMBusHostNotify. Examples of restrictions are > + more reserved addresses and timeout definitions. > + > +- smbus-alert > + states that the optional SMBus-Alert feature apply to this bus. > > Required properties (per child device) > -------------------------------------- > -- > 2.7.4 >
> This needs to be added to i2c-bus.yaml too.
We don't have that yet? Am I missing something?
On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote: > Since SMBus-Alert is an optional feature of SMBUS which > requires an additional pin, the smbus binding cannot be > used to indicate its support. > > Add an additional smbus-alert binding specific for it and > update the description text of smbus to avoid mentioning > SMBus-Alert > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> Applied to for-next, thanks!
diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt index df41f72afc87..b864916e087f 100644 --- a/Documentation/devicetree/bindings/i2c/i2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c.txt @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings. - smbus states that additional SMBus restrictions and features apply to this bus. - Examples of features are SMBusHostNotify and SMBusAlert. Examples of - restrictions are more reserved addresses and timeout definitions. + An example of feature is SMBusHostNotify. Examples of restrictions are + more reserved addresses and timeout definitions. + +- smbus-alert + states that the optional SMBus-Alert feature apply to this bus. Required properties (per child device) --------------------------------------
Since SMBus-Alert is an optional feature of SMBUS which requires an additional pin, the smbus binding cannot be used to indicate its support. Add an additional smbus-alert binding specific for it and update the description text of smbus to avoid mentioning SMBus-Alert Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)