| Message ID | 20210525172628.2088-3-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | enable LPI and ITS for TCG | expand |
On 2021/5/26 1:26, Alex Bennée wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Shashi Mallela <shashi.mallela@linaro.org> This works for me. Tested-by: Zenghui Yu <yuzenghui@huawei.com>
Hi Alex, On 5/25/21 7:26 PM, Alex Bennée wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Shashi Mallela <shashi.mallela@linaro.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > --- > scripts/arch-run.bash | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 5997e38..70693f2 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -122,14 +122,14 @@ run_migration () > trap 'kill 0; exit 2' INT TERM > trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT > > - eval "$@" -chardev socket,id=mon1,path=${qmp1},server,nowait \ > + eval "$@" -chardev socket,id=mon1,path=${qmp1},server=on,wait=off \ > -mon chardev=mon1,mode=control | tee ${migout1} & > > # We have to use cat to open the named FIFO, because named FIFO's, unlike > # pipes, will block on open() until the other end is also opened, and that > # totally breaks QEMU... > mkfifo ${fifo} > - eval "$@" -chardev socket,id=mon2,path=${qmp2},server,nowait \ > + eval "$@" -chardev socket,id=mon2,path=${qmp2},server=on,wait=off \ > -mon chardev=mon2,mode=control -incoming unix:${migsock} < <(cat ${fifo}) & > incoming_pid=`jobs -l %+ | awk '{print$2}'` > >
On Tue, May 25, 2021 at 06:26:26PM +0100, Alex Bennée wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Shashi Mallela <shashi.mallela@linaro.org> > --- > scripts/arch-run.bash | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Andrew Jones <drjones@redhat.com>
On Tue, May 25, 2021 at 06:26:26PM +0100, Alex Bennée wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Shashi Mallela <shashi.mallela@linaro.org> > --- > scripts/arch-run.bash | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 5997e38..70693f2 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -122,14 +122,14 @@ run_migration () > trap 'kill 0; exit 2' INT TERM > trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT > > - eval "$@" -chardev socket,id=mon1,path=${qmp1},server,nowait \ > + eval "$@" -chardev socket,id=mon1,path=${qmp1},server=on,wait=off \ > -mon chardev=mon1,mode=control | tee ${migout1} & > > # We have to use cat to open the named FIFO, because named FIFO's, unlike > # pipes, will block on open() until the other end is also opened, and that > # totally breaks QEMU... > mkfifo ${fifo} > - eval "$@" -chardev socket,id=mon2,path=${qmp2},server,nowait \ > + eval "$@" -chardev socket,id=mon2,path=${qmp2},server=on,wait=off \ > -mon chardev=mon2,mode=control -incoming unix:${migsock} < <(cat ${fifo}) & > incoming_pid=`jobs -l %+ | awk '{print$2}'` > > -- > 2.20.1 > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm Applied to misc/queue https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/misc/queue Thanks, drew
diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 5997e38..70693f2 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -122,14 +122,14 @@ run_migration () trap 'kill 0; exit 2' INT TERM trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT - eval "$@" -chardev socket,id=mon1,path=${qmp1},server,nowait \ + eval "$@" -chardev socket,id=mon1,path=${qmp1},server=on,wait=off \ -mon chardev=mon1,mode=control | tee ${migout1} & # We have to use cat to open the named FIFO, because named FIFO's, unlike # pipes, will block on open() until the other end is also opened, and that # totally breaks QEMU... mkfifo ${fifo} - eval "$@" -chardev socket,id=mon2,path=${qmp2},server,nowait \ + eval "$@" -chardev socket,id=mon2,path=${qmp2},server=on,wait=off \ -mon chardev=mon2,mode=control -incoming unix:${migsock} < <(cat ${fifo}) & incoming_pid=`jobs -l %+ | awk '{print$2}'`
The very fact that QEMU drops the deprecation warning while running is enough to confuse the its-migration test into failing. The boolean options server and wait have accepted the long form options for a long time. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Shashi Mallela <shashi.mallela@linaro.org> --- scripts/arch-run.bash | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)