| Message ID | d107d1840b83607baee8571cc5d88973fc32b519.1622015323.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL | expand |
Hi Geert, Thank you for your patch. On 26/5/21 9:50, Geert Uytterhoeven wrote: > The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded > Controller, and is accessed using I2C tunneling through the Embedded > Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent > asking the user about this driver when configuring a kernel without > support for the ChromeOS EC tunnel I2C bus. > > Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033 > config DRM_CROS_EC_ANX7688 > tristate "ChromeOS EC ANX7688 bridge" > depends on OF > + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST > select DRM_KMS_HELPER > select REGMAP_I2C > help >
Pushed to drm-misc-next. On Thu, 27 May 2021 at 13:07, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Hi Geert, > > Thank you for your patch. > > On 26/5/21 9:50, Geert Uytterhoeven wrote: > > The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded > > Controller, and is accessed using I2C tunneling through the Embedded > > Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent > > asking the user about this driver when configuring a kernel without > > support for the ChromeOS EC tunnel I2C bus. > > > > Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > > --- > > drivers/gpu/drm/bridge/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033 > > config DRM_CROS_EC_ANX7688 > > tristate "ChromeOS EC ANX7688 bridge" > > depends on OF > > + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST > > select DRM_KMS_HELPER > > select REGMAP_I2C > > help > >
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033 config DRM_CROS_EC_ANX7688 tristate "ChromeOS EC ANX7688 bridge" depends on OF + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST select DRM_KMS_HELPER select REGMAP_I2C help
The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded Controller, and is accessed using I2C tunneling through the Embedded Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent asking the user about this driver when configuring a kernel without support for the ChromeOS EC tunnel I2C bus. Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+)