diff mbox series

[-next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()

Message ID 20210518141108.1324127-1-yangyingliang@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] dmaengine: stedma40: add missing iounmap() on error in d40_probe() | expand

Commit Message

Yang Yingliang May 18, 2021, 2:11 p.m. UTC
Add the missing iounmap() before return from d40_probe()
in the error handling case.

Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/dma/ste_dma40.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Linus Walleij May 22, 2021, 12:01 a.m. UTC | #1
On Tue, May 18, 2021 at 4:09 PM Yang Yingliang <yangyingliang@huawei.com> wrote:

> Add the missing iounmap() before return from d40_probe()
> in the error handling case.
>
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Vinod Koul May 31, 2021, 4:17 a.m. UTC | #2
On 18-05-21, 22:11, Yang Yingliang wrote:
> Add the missing iounmap() before return from d40_probe()
> in the error handling case.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 265d7c07b348..e1827393143f 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3675,6 +3675,9 @@  static int __init d40_probe(struct platform_device *pdev)
 
 	kfree(base->lcla_pool.base_unaligned);
 
+	if (base->lcpa_base)
+		iounmap(base->lcpa_base);
+
 	if (base->phy_lcpa)
 		release_mem_region(base->phy_lcpa,
 				   base->lcpa_size);