mbox series

[0/2] allow blk-zoned ioctls without CAP_SYS_ADMIN

Message ID 20210531135444.122018-1-Niklas.Cassel@wdc.com (mailing list archive)
Headers show
Series allow blk-zoned ioctls without CAP_SYS_ADMIN | expand

Message

Niklas Cassel May 31, 2021, 1:54 p.m. UTC 
From: Niklas Cassel <niklas.cassel@wdc.com>

Allow the following blk-zoned ioctls: BLKREPORTZONE, BLKRESETZONE,
BLKOPENZONE, BLKCLOSEZONE, and BLKFINISHZONE to be performed without
CAP_SYS_ADMIN.

These ioctls instead only requires that the corresponding R/W access
control flag to be successfully set on the opened file descriptor.

(open()/openat() will fail with -EPERM if you try to open a file with
flags that you lack permission for.)

Niklas Cassel (2):
  blk-zoned: allow zone management send operations without CAP_SYS_ADMIN
  blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN

 block/blk-zoned.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Damien Le Moal May 31, 2021, 11:34 p.m. UTC | #1 
On 2021/05/31 22:54, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> 
> Allow the following blk-zoned ioctls: BLKREPORTZONE, BLKRESETZONE,
> BLKOPENZONE, BLKCLOSEZONE, and BLKFINISHZONE to be performed without
> CAP_SYS_ADMIN.
> 
> These ioctls instead only requires that the corresponding R/W access
> control flag to be successfully set on the opened file descriptor.
> 
> (open()/openat() will fail with -EPERM if you try to open a file with
> flags that you lack permission for.)
> 
> Niklas Cassel (2):
>   blk-zoned: allow zone management send operations without CAP_SYS_ADMIN
>   blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
> 
>  block/blk-zoned.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 

Looks good to me. For the series:

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

Note that it may be good to have a Fixes & Cc:stable tag for both patches, no ?