[BlueZ,1/3] emulator/btdev: Enable LE Privacy feature

Commit Message

Tedd Ho-Jeong An June 1, 2021, 8:19 p.m. UTC

From: Tedd Ho-Jeong An <[e-mail]>

This patch enables LE Privacy to support LL Privacy feature.
---
 emulator/btdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

[e-mail] June 1, 2021, 9:11 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=492055

---Test result---

Test Summary:
CheckPatch                    FAIL      1.00 seconds
GitLint                       PASS      0.32 seconds
Prep - Setup ELL              PASS      41.00 seconds
Build - Prep                  PASS      0.10 seconds
Build - Configure             PASS      7.22 seconds
Build - Make                  PASS      176.73 seconds
Make Check                    PASS      9.25 seconds
Make Distcheck                PASS      208.95 seconds
Build w/ext ELL - Configure   PASS      7.20 seconds
Build w/ext ELL - Make        PASS      165.59 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
tools/mgmt-tester: Add tests for experimental feature command
WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#17: FILE: tools/mgmt-tester.c:6840:
+			tester_warn("Invalid cmd response parameter size: %d", length);

- total: 0 errors, 1 warnings, 156 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] tools/mgmt-tester: Add tests for experimental feature command" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

tools/mgmt-tester: Add tests for whitelist and resolving list
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#163: FILE: tools/mgmt-tester.c:6988:
+		tester_warn("Invalid parameter size for HCI command (%d)", length);

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#172: FILE: tools/mgmt-tester.c:7021:
+		tester_warn("Invalid parameter size for HCI command (%d)", length);

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#240: FILE: tools/mgmt-tester.c:9396:
+	mgmt_send(data->mgmt, MGMT_OP_SET_EXP_FEATURE , data->mgmt_index,
 	                                              ^

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#298: FILE: tools/mgmt-tester.c:9454:
+	mgmt_send(data->mgmt, MGMT_OP_SET_EXP_FEATURE , data->mgmt_index,
 	                                              ^

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#358: FILE: tools/mgmt-tester.c:9514:
+	mgmt_send(data->mgmt, MGMT_OP_SET_EXP_FEATURE , data->mgmt_index,
 	                                              ^

- total: 3 errors, 2 warnings, 420 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] tools/mgmt-tester: Add tests for whitelist and resolving list" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth

Patch

diff --git a/emulator/btdev.c b/emulator/btdev.c
index 692fabd71..13abad577 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -5415,6 +5415,7 @@  static void set_bredrle_features(struct btdev *btdev)
 		btdev->features[4] |= 0x80;	/* 3 slot EDR ACL packets */
 		btdev->features[5] |= 0x01;	/* 5 slot EDR ACL packets */
 
+		btdev->le_features[0] |= 0x40;	/* LE PRIVACY */
 		btdev->le_features[1] |= 0x01;	/* LE 2M PHY */
 		btdev->le_features[1] |= 0x08;	/* LE Coded PHY */
 		btdev->le_features[1] |= 0x10;  /* LE EXT ADV */