| Message ID | 1622616132-10391-1-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4b1d51715d1cf78a1527fe426fc0278dcfea1959 |
| Headers | show |
| Series | ASoC: fsl-asoc-card: change dev_err to dev_dbg for defer probe | expand |
Hi Shengjiu, On Wed, Jun 2, 2021 at 3:59 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote: > > Don't need to print error message for defer probe ... > if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) { > - dev_err(&pdev->dev, "failed to find codec device\n"); > + dev_dbg(&pdev->dev, "failed to find codec device\n"); You may consider using dev_err_probe() here, which fits exactly this purpose.
On Wed, Jun 2, 2021 at 11:45 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Shengjiu, > > On Wed, Jun 2, 2021 at 3:59 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote: > > > > Don't need to print error message for defer probe > ... > > if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) { > > - dev_err(&pdev->dev, "failed to find codec device\n"); > > + dev_dbg(&pdev->dev, "failed to find codec device\n"); > > You may consider using dev_err_probe() here, which fits exactly this purpose. ok, let me update it. best regards wang shengjiu
Hi Shengjiu, On Wed, Jun 2, 2021 at 3:59 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote: > > Don't need to print error message for defer probe > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- > sound/soc/fsl/fsl-asoc-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c > index 4f55b316cf0f..b40ba910ae9d 100644 > --- a/sound/soc/fsl/fsl-asoc-card.c > +++ b/sound/soc/fsl/fsl-asoc-card.c > @@ -709,7 +709,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) > of_node_put(framemaster); > > if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) { > - dev_err(&pdev->dev, "failed to find codec device\n"); > + dev_dbg(&pdev->dev, "failed to find codec device\n"); > ret = -EPROBE_DEFER; This looks good: Reviewed-by: Fabio Estevam <festevam@gmail.com> My previous suggestion of using dev_err_probe() would make the message never to be printed. Thanks
On Wed, 2 Jun 2021 14:42:12 +0800, Shengjiu Wang wrote:
> Don't need to print error message for defer probe
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: fsl-asoc-card: change dev_err to dev_dbg for defer probe
commit: 4b1d51715d1cf78a1527fe426fc0278dcfea1959
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 4f55b316cf0f..b40ba910ae9d 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -709,7 +709,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) of_node_put(framemaster); if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) { - dev_err(&pdev->dev, "failed to find codec device\n"); + dev_dbg(&pdev->dev, "failed to find codec device\n"); ret = -EPROBE_DEFER; goto asrc_fail; }
Don't need to print error message for defer probe Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)