| Message ID | 20210601201702.23316-1-andrey.grodzovsky@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | libdrm tests for hot-unplug feature | expand |
On Tue, Jun 1, 2021 at 10:17 PM Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote: > Adding some tests to acompany the recently added hot-unplug > feature. For now the test suite is disabled until the feature > propagates from drm-misc-next to drm-next. > > Andrey Grodzovsky (7): > tests/amdgpu: Fix valgrind warning > xf86drm: Add function to retrieve char device path > test/amdgpu: Add helper functions for hot unplug > test/amdgpu/hotunplug: Add test suite for GPU unplug > test/amdgpu/hotunplug: Add basic test > tests/amdgpu/hotunplug: Add unplug with cs test. > tests/amdgpu/hotunplug: Add hotunplug with exported bo test Given how nasty hotunplug is I really think collaborating on igt tests on this would be best for everyone ... do we have to keep doing parallel tests here for amdgpu? -Daniel > tests/amdgpu/amdgpu_test.c | 42 +++- > tests/amdgpu/amdgpu_test.h | 26 +++ > tests/amdgpu/basic_tests.c | 5 +- > tests/amdgpu/hotunplug_tests.c | 357 +++++++++++++++++++++++++++++++++ > tests/amdgpu/meson.build | 1 + > xf86drm.c | 23 +++ > xf86drm.h | 1 + > 7 files changed, 450 insertions(+), 5 deletions(-) > create mode 100644 tests/amdgpu/hotunplug_tests.c > > -- > 2.25.1 >
On 2021-06-02 3:59 a.m., Daniel Vetter wrote: > On Tue, Jun 1, 2021 at 10:17 PM Andrey Grodzovsky > <andrey.grodzovsky@amd.com> wrote: >> Adding some tests to acompany the recently added hot-unplug >> feature. For now the test suite is disabled until the feature >> propagates from drm-misc-next to drm-next. >> >> Andrey Grodzovsky (7): >> tests/amdgpu: Fix valgrind warning >> xf86drm: Add function to retrieve char device path >> test/amdgpu: Add helper functions for hot unplug >> test/amdgpu/hotunplug: Add test suite for GPU unplug >> test/amdgpu/hotunplug: Add basic test >> tests/amdgpu/hotunplug: Add unplug with cs test. >> tests/amdgpu/hotunplug: Add hotunplug with exported bo test > Given how nasty hotunplug is I really think collaborating on igt tests > on this would be best for everyone ... do we have to keep doing > parallel tests here for amdgpu? > -Daniel AFAIK as far as AMD goes a lot of developers use libdrm for regression testing while developing their features and also QA as i can see from some internal ticket specifically opened for failing to pass libdrm tests. From my bitter experience with GPU reset - features which are not part of a common use case such as device loading, mode setting or commands submissions tend to very quickly break as people develop features but never test them in those uncommon use cases - this is why I feel it will be very helpful to include those tests in libdrm. Also given that this is libdrm amdgpu code it fits naturally into libdrm. Regarding IGT - as you may remember I have them there too - https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master I hit some compile breakage on debian platform there which i need to resolve before i will submit for review there too. Andrey > >> tests/amdgpu/amdgpu_test.c | 42 +++- >> tests/amdgpu/amdgpu_test.h | 26 +++ >> tests/amdgpu/basic_tests.c | 5 +- >> tests/amdgpu/hotunplug_tests.c | 357 +++++++++++++++++++++++++++++++++ >> tests/amdgpu/meson.build | 1 + >> xf86drm.c | 23 +++ >> xf86drm.h | 1 + >> 7 files changed, 450 insertions(+), 5 deletions(-) >> create mode 100644 tests/amdgpu/hotunplug_tests.c >> >> -- >> 2.25.1 >> >
Ping Andrey On 2021-06-02 10:20 a.m., Andrey Grodzovsky wrote: > > On 2021-06-02 3:59 a.m., Daniel Vetter wrote: >> On Tue, Jun 1, 2021 at 10:17 PM Andrey Grodzovsky >> <andrey.grodzovsky@amd.com> wrote: >>> Adding some tests to acompany the recently added hot-unplug >>> feature. For now the test suite is disabled until the feature >>> propagates from drm-misc-next to drm-next. >>> >>> Andrey Grodzovsky (7): >>> tests/amdgpu: Fix valgrind warning >>> xf86drm: Add function to retrieve char device path >>> test/amdgpu: Add helper functions for hot unplug >>> test/amdgpu/hotunplug: Add test suite for GPU unplug >>> test/amdgpu/hotunplug: Add basic test >>> tests/amdgpu/hotunplug: Add unplug with cs test. >>> tests/amdgpu/hotunplug: Add hotunplug with exported bo test >> Given how nasty hotunplug is I really think collaborating on igt tests >> on this would be best for everyone ... do we have to keep doing >> parallel tests here for amdgpu? >> -Daniel > > AFAIK as far as AMD goes a lot of developers use libdrm for regression > testing > while developing their features and also QA as i can see from some > internal ticket > specifically opened for failing to pass libdrm tests. From my bitter > experience with > GPU reset - features which are not part of a common use case such as > device loading, > mode setting or commands submissions tend to very quickly break as > people develop > features but never test them in those uncommon use cases - this is why > I feel it will be > very helpful to include those tests in libdrm. > > Also given that this is libdrm amdgpu code it fits naturally into libdrm. > > Regarding IGT - as you may remember I have them there too - > https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master > I hit some compile breakage on debian platform there which i need to > resolve before i will submit for review there too. > > Andrey > > >> >>> tests/amdgpu/amdgpu_test.c | 42 +++- >>> tests/amdgpu/amdgpu_test.h | 26 +++ >>> tests/amdgpu/basic_tests.c | 5 +- >>> tests/amdgpu/hotunplug_tests.c | 357 >>> +++++++++++++++++++++++++++++++++ >>> tests/amdgpu/meson.build | 1 + >>> xf86drm.c | 23 +++ >>> xf86drm.h | 1 + >>> 7 files changed, 450 insertions(+), 5 deletions(-) >>> create mode 100644 tests/amdgpu/hotunplug_tests.c >>> >>> -- >>> 2.25.1 >>> >>
On Thu, Jun 03, 2021 at 10:22:37AM -0400, Andrey Grodzovsky wrote: > Ping > > Andrey > > On 2021-06-02 10:20 a.m., Andrey Grodzovsky wrote: > > > > On 2021-06-02 3:59 a.m., Daniel Vetter wrote: > > > On Tue, Jun 1, 2021 at 10:17 PM Andrey Grodzovsky > > > <andrey.grodzovsky@amd.com> wrote: > > > > Adding some tests to acompany the recently added hot-unplug > > > > feature. For now the test suite is disabled until the feature > > > > propagates from drm-misc-next to drm-next. > > > > > > > > Andrey Grodzovsky (7): > > > > tests/amdgpu: Fix valgrind warning > > > > xf86drm: Add function to retrieve char device path > > > > test/amdgpu: Add helper functions for hot unplug > > > > test/amdgpu/hotunplug: Add test suite for GPU unplug > > > > test/amdgpu/hotunplug: Add basic test > > > > tests/amdgpu/hotunplug: Add unplug with cs test. > > > > tests/amdgpu/hotunplug: Add hotunplug with exported bo test > > > Given how nasty hotunplug is I really think collaborating on igt tests > > > on this would be best for everyone ... do we have to keep doing > > > parallel tests here for amdgpu? > > > -Daniel > > > > AFAIK as far as AMD goes a lot of developers use libdrm for regression > > testing > > while developing their features and also QA as i can see from some > > internal ticket > > specifically opened for failing to pass libdrm tests. From my bitter > > experience with > > GPU reset - features which are not part of a common use case such as > > device loading, > > mode setting or commands submissions tend to very quickly break as > > people develop > > features but never test them in those uncommon use cases - this is why I > > feel it will be > > very helpful to include those tests in libdrm. > > > > Also given that this is libdrm amdgpu code it fits naturally into libdrm. > > > > Regarding IGT - as you may remember I have them there too - > > https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master > > I hit some compile breakage on debian platform there which i need to > > resolve before i will submit for review there too. Why can't amd run the igt tests? Afaiui on the display side this is happening already, at least sometimes. And yes regression tests matter, it just feels silly that we need to have them 2x for amdgpu. For old stuff the old repo is all fine, but for new feature it looks a bit silly. -Daniel > > > > Andrey > > > > > > > > > > > tests/amdgpu/amdgpu_test.c | 42 +++- > > > > tests/amdgpu/amdgpu_test.h | 26 +++ > > > > tests/amdgpu/basic_tests.c | 5 +- > > > > tests/amdgpu/hotunplug_tests.c | 357 > > > > +++++++++++++++++++++++++++++++++ > > > > tests/amdgpu/meson.build | 1 + > > > > xf86drm.c | 23 +++ > > > > xf86drm.h | 1 + > > > > 7 files changed, 450 insertions(+), 5 deletions(-) > > > > create mode 100644 tests/amdgpu/hotunplug_tests.c > > > > > > > > -- > > > > 2.25.1 > > > > > > >
On Thu, Jun 3, 2021 at 5:11 PM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Thu, Jun 03, 2021 at 10:22:37AM -0400, Andrey Grodzovsky wrote: > > Ping > > > > Andrey > > > > On 2021-06-02 10:20 a.m., Andrey Grodzovsky wrote: > > > > > > On 2021-06-02 3:59 a.m., Daniel Vetter wrote: > > > > On Tue, Jun 1, 2021 at 10:17 PM Andrey Grodzovsky > > > > <andrey.grodzovsky@amd.com> wrote: > > > > > Adding some tests to acompany the recently added hot-unplug > > > > > feature. For now the test suite is disabled until the feature > > > > > propagates from drm-misc-next to drm-next. > > > > > > > > > > Andrey Grodzovsky (7): > > > > > tests/amdgpu: Fix valgrind warning > > > > > xf86drm: Add function to retrieve char device path > > > > > test/amdgpu: Add helper functions for hot unplug > > > > > test/amdgpu/hotunplug: Add test suite for GPU unplug > > > > > test/amdgpu/hotunplug: Add basic test > > > > > tests/amdgpu/hotunplug: Add unplug with cs test. > > > > > tests/amdgpu/hotunplug: Add hotunplug with exported bo test > > > > Given how nasty hotunplug is I really think collaborating on igt tests > > > > on this would be best for everyone ... do we have to keep doing > > > > parallel tests here for amdgpu? > > > > -Daniel > > > > > > AFAIK as far as AMD goes a lot of developers use libdrm for regression > > > testing > > > while developing their features and also QA as i can see from some > > > internal ticket > > > specifically opened for failing to pass libdrm tests. From my bitter > > > experience with > > > GPU reset - features which are not part of a common use case such as > > > device loading, > > > mode setting or commands submissions tend to very quickly break as > > > people develop > > > features but never test them in those uncommon use cases - this is why I > > > feel it will be > > > very helpful to include those tests in libdrm. > > > > > > Also given that this is libdrm amdgpu code it fits naturally into libdrm. > > > > > > Regarding IGT - as you may remember I have them there too - > > > https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master > > > I hit some compile breakage on debian platform there which i need to > > > resolve before i will submit for review there too. > > Why can't amd run the igt tests? Afaiui on the display side this is > happening already, at least sometimes. > > And yes regression tests matter, it just feels silly that we need to have > them 2x for amdgpu. For old stuff the old repo is all fine, but for new > feature it looks a bit silly. Different teams, different CI infrastructures... It ends up being easier to port tests between frameworks than to switch frameworks in some cases. Alex > -Daniel > > > > > > > Andrey > > > > > > > > > > > > > > > tests/amdgpu/amdgpu_test.c | 42 +++- > > > > > tests/amdgpu/amdgpu_test.h | 26 +++ > > > > > tests/amdgpu/basic_tests.c | 5 +- > > > > > tests/amdgpu/hotunplug_tests.c | 357 > > > > > +++++++++++++++++++++++++++++++++ > > > > > tests/amdgpu/meson.build | 1 + > > > > > xf86drm.c | 23 +++ > > > > > xf86drm.h | 1 + > > > > > 7 files changed, 450 insertions(+), 5 deletions(-) > > > > > create mode 100644 tests/amdgpu/hotunplug_tests.c > > > > > > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
Please open a gitlab MR for these. Alex On Tue, Jun 1, 2021 at 4:17 PM Andrey Grodzovsky <andrey.grodzovsky@amd.com> wrote: > > Adding some tests to acompany the recently added hot-unplug > feature. For now the test suite is disabled until the feature > propagates from drm-misc-next to drm-next. > > Andrey Grodzovsky (7): > tests/amdgpu: Fix valgrind warning > xf86drm: Add function to retrieve char device path > test/amdgpu: Add helper functions for hot unplug > test/amdgpu/hotunplug: Add test suite for GPU unplug > test/amdgpu/hotunplug: Add basic test > tests/amdgpu/hotunplug: Add unplug with cs test. > tests/amdgpu/hotunplug: Add hotunplug with exported bo test > > tests/amdgpu/amdgpu_test.c | 42 +++- > tests/amdgpu/amdgpu_test.h | 26 +++ > tests/amdgpu/basic_tests.c | 5 +- > tests/amdgpu/hotunplug_tests.c | 357 +++++++++++++++++++++++++++++++++ > tests/amdgpu/meson.build | 1 + > xf86drm.c | 23 +++ > xf86drm.h | 1 + > 7 files changed, 450 insertions(+), 5 deletions(-) > create mode 100644 tests/amdgpu/hotunplug_tests.c > > -- > 2.25.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Is libdrm on gitlab ? I wasn't aware of this. I assumed code reviews still go through dri-devel. Andrey
On Fri, 4 Jun 2021 at 07:20, Alex Deucher <alexdeucher@gmail.com> wrote: > > Please open a gitlab MR for these. > I'd really prefer these tests all get migrated out of here into igt. I don't think libdrm_amdgpu really should have tests that test the kernel level infrastructure. I know some people at AMD had issues in the past with igt because the i might have stood for intel back in time, but at this point I think we should be moving past that. Dave.
Code review happens on gitlab now for libdrm. Alex On Thu, Jun 3, 2021 at 6:02 PM Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> wrote: > > Is libdrm on gitlab ? I wasn't aware of this. I assumed code reviews still go through dri-devel. > > Andrey > > ________________________________ > From: Alex Deucher <alexdeucher@gmail.com> > Sent: 03 June 2021 17:20 > To: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> > Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>; amd-gfx list <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Christian König <ckoenig.leichtzumerken@gmail.com> > Subject: Re: [PATCH 0/7] libdrm tests for hot-unplug feature > > Please open a gitlab MR for these. > > Alex > > On Tue, Jun 1, 2021 at 4:17 PM Andrey Grodzovsky > <andrey.grodzovsky@amd.com> wrote: > > > > Adding some tests to acompany the recently added hot-unplug > > feature. For now the test suite is disabled until the feature > > propagates from drm-misc-next to drm-next. > > > > Andrey Grodzovsky (7): > > tests/amdgpu: Fix valgrind warning > > xf86drm: Add function to retrieve char device path > > test/amdgpu: Add helper functions for hot unplug > > test/amdgpu/hotunplug: Add test suite for GPU unplug > > test/amdgpu/hotunplug: Add basic test > > tests/amdgpu/hotunplug: Add unplug with cs test. > > tests/amdgpu/hotunplug: Add hotunplug with exported bo test > > > > tests/amdgpu/amdgpu_test.c | 42 +++- > > tests/amdgpu/amdgpu_test.h | 26 +++ > > tests/amdgpu/basic_tests.c | 5 +- > > tests/amdgpu/hotunplug_tests.c | 357 +++++++++++++++++++++++++++++++++ > > tests/amdgpu/meson.build | 1 + > > xf86drm.c | 23 +++ > > xf86drm.h | 1 + > > 7 files changed, 450 insertions(+), 5 deletions(-) > > create mode 100644 tests/amdgpu/hotunplug_tests.c > > > > -- > > 2.25.1 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Candrey.grodzovsky%40amd.com%7C8fb7f614798b4d19572e08d926d57530%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637583520507282588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ozqlNQACGvLJugQ2GNvFl8CKgAH0thqMRpWjHpURlyc%3D&reserved=0
On Thu, Jun 3, 2021 at 9:37 PM Dave Airlie <airlied@gmail.com> wrote: > > On Fri, 4 Jun 2021 at 07:20, Alex Deucher <alexdeucher@gmail.com> wrote: > > > > Please open a gitlab MR for these. > > > > I'd really prefer these tests all get migrated out of here into igt. I > don't think libdrm_amdgpu really should have tests that test the > kernel level infrastructure. > We are providing equivalent patches for IGT as well. There are some teams and customers that would prefer to stick with libdrm_amdgpu. > I know some people at AMD had issues in the past with igt because the > i might have stood for intel back in time, but at this point I think > we should be moving past that. I don't think that was ever an issue. It's more that some teams built a bunch of infrastructure that used libdrm tests and haven't had the resources to switch to IGT yet. Alex
On 2021-06-03 10:53 p.m., Alex Deucher wrote: > On Thu, Jun 3, 2021 at 9:37 PM Dave Airlie <airlied@gmail.com> wrote: >> On Fri, 4 Jun 2021 at 07:20, Alex Deucher <alexdeucher@gmail.com> wrote: >>> Please open a gitlab MR for these. >>> >> I'd really prefer these tests all get migrated out of here into igt. I >> don't think libdrm_amdgpu really should have tests that test the >> kernel level infrastructure. >> I am also a bit confused now what's the policy about libdrm - is it being slowly deprecated ? What tests should go to IGT and what to libdrm ? The kernel feature itself is strictly amdgpu specific and not generic DRM level feature - why then it's not a good fit for amdgpu tester ? > We are providing equivalent patches for IGT as well. There are some > teams and customers that would prefer to stick with libdrm_amdgpu. Here are the patches in my cloned gitlab repo - https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master and I sent today for review to igt-dev@lists.freedesktop.org too. Andrey > >> I know some people at AMD had issues in the past with igt because the >> i might have stood for intel back in time, but at this point I think >> we should be moving past that. > I don't think that was ever an issue. It's more that some teams built > a bunch of infrastructure that used libdrm tests and haven't had the > resources to switch to IGT yet. > > Alex
Hey, MR created at https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172, please help review. Andrey On 2021-06-03 10:26 p.m., Alex Deucher wrote: > Code review happens on gitlab now for libdrm. > > Alex > > On Thu, Jun 3, 2021 at 6:02 PM Grodzovsky, Andrey > <Andrey.Grodzovsky@amd.com> wrote: >> Is libdrm on gitlab ? I wasn't aware of this. I assumed code reviews still go through dri-devel. >> >> Andrey >> >> ________________________________ >> From: Alex Deucher <alexdeucher@gmail.com> >> Sent: 03 June 2021 17:20 >> To: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com> >> Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>; amd-gfx list <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Christian König <ckoenig.leichtzumerken@gmail.com> >> Subject: Re: [PATCH 0/7] libdrm tests for hot-unplug feature >> >> Please open a gitlab MR for these. >> >> Alex >> >> On Tue, Jun 1, 2021 at 4:17 PM Andrey Grodzovsky >> <andrey.grodzovsky@amd.com> wrote: >>> Adding some tests to acompany the recently added hot-unplug >>> feature. For now the test suite is disabled until the feature >>> propagates from drm-misc-next to drm-next. >>> >>> Andrey Grodzovsky (7): >>> tests/amdgpu: Fix valgrind warning >>> xf86drm: Add function to retrieve char device path >>> test/amdgpu: Add helper functions for hot unplug >>> test/amdgpu/hotunplug: Add test suite for GPU unplug >>> test/amdgpu/hotunplug: Add basic test >>> tests/amdgpu/hotunplug: Add unplug with cs test. >>> tests/amdgpu/hotunplug: Add hotunplug with exported bo test >>> >>> tests/amdgpu/amdgpu_test.c | 42 +++- >>> tests/amdgpu/amdgpu_test.h | 26 +++ >>> tests/amdgpu/basic_tests.c | 5 +- >>> tests/amdgpu/hotunplug_tests.c | 357 +++++++++++++++++++++++++++++++++ >>> tests/amdgpu/meson.build | 1 + >>> xf86drm.c | 23 +++ >>> xf86drm.h | 1 + >>> 7 files changed, 450 insertions(+), 5 deletions(-) >>> create mode 100644 tests/amdgpu/hotunplug_tests.c >>> >>> -- >>> 2.25.1 >>> >>> _______________________________________________ >>> amd-gfx mailing list >>> amd-gfx@lists.freedesktop.org >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C155b8cb8d6834e86275a08d927004117%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637583704326965590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=AclAYkIS4xlE6cpmmaMyIo86gJ70Pk%2FkqJncGNAM3cw%3D&reserved=0