| Message ID | pull.968.git.1622634446643.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fe4c6280bc1a2e64df6d719cc6c30d81c365384b |
| Headers | show |
| Series | Remove warning that repack only works on non-promisor packfiles | expand |
On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote: > From: Tao Klerks <tao@klerks.biz> > > The git-repack doc clearly states that it *does* operate on promisor > packfiles (in a separate partition), with "-a" specified. Presumably > the statements here are outdated, as they feature from the first doc > in 2017 (and the repack support was added in 2018) Yeah, this all originally comes from Jeff H.'s design document in 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should have been updated in 5d19e8138d (repack: repack promisor objects if -a or -A is set, 2018-08-08). This looks good to me, but I'll add Jonathan Tan to the CC list to double check. Reviewed-by: Taylor Blau <me@ttaylorr.com> Thanks, Taylor
> On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote: > > From: Tao Klerks <tao@klerks.biz> > > > > The git-repack doc clearly states that it *does* operate on promisor > > packfiles (in a separate partition), with "-a" specified. Presumably > > the statements here are outdated, as they feature from the first doc > > in 2017 (and the repack support was added in 2018) > > Yeah, this all originally comes from Jeff H.'s design document in > 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should > have been updated in 5d19e8138d (repack: repack promisor objects if -a > or -A is set, 2018-08-08). > > This looks good to me, but I'll add Jonathan Tan to the CC list to > double check. > > Reviewed-by: Taylor Blau <me@ttaylorr.com> Thanks, Taylor. Yes, the patch is correct.
Jonathan Tan <jonathantanmy@google.com> writes: >> On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote: >> > From: Tao Klerks <tao@klerks.biz> >> > >> > The git-repack doc clearly states that it *does* operate on promisor >> > packfiles (in a separate partition), with "-a" specified. Presumably >> > the statements here are outdated, as they feature from the first doc >> > in 2017 (and the repack support was added in 2018) >> >> Yeah, this all originally comes from Jeff H.'s design document in >> 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should >> have been updated in 5d19e8138d (repack: repack promisor objects if -a >> or -A is set, 2018-08-08). >> >> This looks good to me, but I'll add Jonathan Tan to the CC list to >> double check. >> >> Reviewed-by: Taylor Blau <me@ttaylorr.com> > > Thanks, Taylor. Yes, the patch is correct. Thanks, all of you. Will queue.
diff --git a/Documentation/technical/partial-clone.txt b/Documentation/technical/partial-clone.txt index 0780d30caca6..a0dd7c66f247 100644 --- a/Documentation/technical/partial-clone.txt +++ b/Documentation/technical/partial-clone.txt @@ -242,8 +242,7 @@ remote in a specific order. repository and can satisfy all such requests. - Repack essentially treats promisor and non-promisor packfiles as 2 - distinct partitions and does not mix them. Repack currently only works - on non-promisor packfiles and loose objects. + distinct partitions and does not mix them. - Dynamic object fetching invokes fetch-pack once *for each item* because most algorithms stumble upon a missing object and need to have @@ -273,9 +272,6 @@ to use those promisor remotes in that order." The user might want to work in a triangular work flow with multiple promisor remotes that each have an incomplete view of the repository. -- Allow repack to work on promisor packfiles (while keeping them distinct - from non-promisor packfiles). - - Allow non-pathname-based filters to make use of packfile bitmaps (when present). This was just an omission during the initial implementation.