| Message ID | 20210604015640.2586269-2-shakeelb@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] memcg: switch lruvec stats to rstat | expand |
On Thu, 3 Jun 2021 18:56:40 -0700 Shakeel Butt wrote: > > +static void flush_memcg_stats(struct work_struct *w) > +{ > + cgroup_rstat_flush(root_mem_cgroup->css.cgroup); > + schedule_delayed_work(&stats_flush, round_jiffies(2UL*HZ)); > +} Given flush may block, the unbound wq is what you need. queue_delayed_work(system_unbound_wq, &stats_flush, 2 * HZ);
On Fri, Jun 04, 2021 at 02:18:16PM +0800, Hillf Danton wrote: > On Thu, 3 Jun 2021 18:56:40 -0700 Shakeel Butt wrote: > > > > +static void flush_memcg_stats(struct work_struct *w) > > +{ > > + cgroup_rstat_flush(root_mem_cgroup->css.cgroup); > > + schedule_delayed_work(&stats_flush, round_jiffies(2UL*HZ)); > > +} > > Given flush may block, the unbound wq is what you need. > > queue_delayed_work(system_unbound_wq, &stats_flush, 2 * HZ); Default per-cpu workqueue can block just fine. I don't see a strong reason why this would need to be unbound.
On Sat, Jun 05, 2021 at 09:54:21AM +0800, Hillf Danton wrote: > The cond_resched() in cgroup_rstat_flush_locked() matches its appearence in > your post [1]. So does unbound IMHO. Ah yeah, this either needs CPU_INTENSIVE or UNBOUND, prolly the latter is better. > And the short stuff [2] looks to me like it is incorrect to queue a work > acquiring mutex lock on to the system_wq. IOW the unbound wq is the right > thing for any work that might sleep. This part doesn't make sense. Blocking from per-cpu workqueue is completely fine. What's not fine is consuming a lot of CPU cycles. Thanks.
On Fri, Jun 4, 2021 at 7:33 PM Tejun Heo <tj@kernel.org> wrote: > > On Sat, Jun 05, 2021 at 09:54:21AM +0800, Hillf Danton wrote: > > The cond_resched() in cgroup_rstat_flush_locked() matches its appearence in > > your post [1]. So does unbound IMHO. > > Ah yeah, this either needs CPU_INTENSIVE or UNBOUND, prolly the latter is > better. > I will change the next version to the system_unbound_wq.
On Fri, 4 Jun 2021 22:33:11 -0400 Tejun Heo wrote: >On Sat, Jun 05, 2021 at 09:54:21AM +0800, Hillf Danton wrote: >> The cond_resched() in cgroup_rstat_flush_locked() matches its appearence in >> your post [1]. So does unbound IMHO. > >Ah yeah, this either needs CPU_INTENSIVE or UNBOUND, prolly the latter is >better. > >> And the short stuff [2] looks to me like it is incorrect to queue a work >> acquiring mutex lock on to the system_wq. IOW the unbound wq is the right >> thing for any work that might sleep. > >This part doesn't make sense. Blocking from per-cpu workqueue is completely >fine. What's not fine is consuming a lot of CPU cycles. Thanks for the light on the per-cpu workqueue - it is difficult to understand that short stuff without it. Hillf
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 81d65d32ec2a..222c00e76ef9 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -991,6 +991,12 @@ static inline unsigned long lruvec_page_state_local(struct lruvec *lruvec, return x; } +static inline void mem_cgroup_flush_stats(void) +{ + if (!mem_cgroup_disabled()) + cgroup_rstat_flush(root_mem_cgroup->css.cgroup); +} + void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, int val); void __mod_lruvec_kmem_state(void *p, enum node_stat_item idx, int val); @@ -1394,6 +1400,10 @@ static inline unsigned long lruvec_page_state_local(struct lruvec *lruvec, return node_page_state(lruvec_pgdat(lruvec), idx); } +static inline void mem_cgroup_flush_stats(void) +{ +} + static inline void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, int val) { diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d48f727bec05..6c8578faa8b4 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -96,6 +96,10 @@ bool cgroup_memory_noswap __read_mostly; static DECLARE_WAIT_QUEUE_HEAD(memcg_cgwb_frn_waitq); #endif +/* Periodically flush memcg and lruvec stats. */ +static void flush_memcg_stats(struct work_struct *w); +static DECLARE_DEFERRABLE_WORK(stats_flush, flush_memcg_stats); + /* Whether legacy memory+swap accounting is active */ static bool do_memsw_account(void) { @@ -5230,6 +5234,10 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css) /* Online state pins memcg ID, memcg ID pins CSS */ refcount_set(&memcg->id.ref, 1); css_get(css); + + if (unlikely(mem_cgroup_is_root(memcg))) + schedule_delayed_work(&stats_flush, round_jiffies(2UL*HZ)); + return 0; } @@ -5321,6 +5329,12 @@ static void mem_cgroup_css_reset(struct cgroup_subsys_state *css) memcg_wb_domain_size_changed(memcg); } +static void flush_memcg_stats(struct work_struct *w) +{ + cgroup_rstat_flush(root_mem_cgroup->css.cgroup); + schedule_delayed_work(&stats_flush, round_jiffies(2UL*HZ)); +} + static void mem_cgroup_css_rstat_flush(struct cgroup_subsys_state *css, int cpu) { struct mem_cgroup *memcg = mem_cgroup_from_css(css); diff --git a/mm/vmscan.c b/mm/vmscan.c index 60a19fd6ea3f..16546a5be922 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3872,6 +3872,12 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx) sc.may_writepage = !laptop_mode && !nr_boost_reclaim; sc.may_swap = !nr_boost_reclaim; + /* + * Flush the memory cgroup stats, so that we read accurate + * per-memcg lruvec stats for heuristics later. + */ + mem_cgroup_flush_stats(); + /* * Do some background aging of the anon list, to give * pages a chance to be referenced before reclaiming. All
At the moment memcg stats are read in four contexts: 1. memcg stat user interfaces 2. dirty throttling 3. page fault 4. memory reclaim Currently the kernel flushes the stats for first two cases. Flushing the stats for remaining two casese may have performance impact. Always flushing the memcg stats on the page fault code path may negatively impacts the performance of the applications. In addition flushing in the memory reclaim code path, though treated as slowpath, can become the source of contention for the global lock taken for stat flushing because when system or memcg is under memory pressure, many tasks may enter the reclaim path. Instead of synchronously flushing the stats, this patch adds support of asynchronous periodic flushing of the memcg stats. For now the flushing period is hardcoded to 2*HZ but that can be changed later through maybe sysctl if need arise. This patch does add the explicit flushing in the kswapd thread as the number of kswapd threads which corresponds to the number of nodes on realistic machines are usually low. Signed-off-by: Shakeel Butt <shakeelb@google.com> --- include/linux/memcontrol.h | 10 ++++++++++ mm/memcontrol.c | 14 ++++++++++++++ mm/vmscan.c | 6 ++++++ 3 files changed, 30 insertions(+)