diff mbox series

[3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8

Message ID 20210605082539.41797-3-jeremy.szu@canonical.com (mailing list archive)
State Accepted
Commit dfb06401b4cdfc71e2fc3e19b877ab845cc9f7f7
Headers show
Series [1/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2 | expand

Commit Message

Jeremy Szu June 5, 2021, 8:25 a.m. UTC
The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to
control mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.

Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai June 5, 2021, 12:52 p.m. UTC | #1
On Sat, 05 Jun 2021 10:25:38 +0200,
Jeremy Szu wrote:
> 
> The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to
> control mute LED and 0x01 to control micmute LED.
> In the other hand, there is no output from right channel of speaker.
> Therefore, add a quirk to make it works.
> 
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>

Applied, thanks.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 11324163ebe1..215beb3ac678 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8330,6 +8330,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
 	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),