| Message ID | 20210429083823.59546-1-jbrunet@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] arm64: meson: select COMMON_CLK | expand |
On Thu, Apr 29, 2021 at 10:39 AM Jerome Brunet <jbrunet@baylibre.com> wrote: > > This fix the recent removal of clock drivers selection. > While it is not necessary to select the clock drivers themselves, we need > to select a proper implementation of the clock API, which for the meson, is > CCF > > Fixes: ba66a25536dd ("arm64: meson: ship only the necessary clock controllers") > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> note to self: ARCH_MULTIPLATFORM for the 32-bit SoCs also selects this
On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: > This fix the recent removal of clock drivers selection. > While it is not necessary to select the clock drivers themselves, we need > to select a proper implementation of the clock API, which for the meson, is > CCF Applied, thanks! [1/1] arm64: meson: select COMMON_CLK commit: aea7a80ad5effd48f44a7a08c3903168be038a43 Best regards,
Hi Jerome, On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: > On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: > > This fix the recent removal of clock drivers selection. > > While it is not necessary to select the clock drivers themselves, we need > > to select a proper implementation of the clock API, which for the meson, is > > CCF > > Applied, thanks! > > [1/1] arm64: meson: select COMMON_CLK > commit: aea7a80ad5effd48f44a7a08c3903168be038a43 > > Best regards, > -- > Kevin Hilman <khilman@baylibre.com> Why is this needed, and why would this make any difference? COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in arch/arm64/Kconfig selects it. Gr{oetje,eeting}s, Geert
On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Jerome, > > On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: >> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: >> > This fix the recent removal of clock drivers selection. >> > While it is not necessary to select the clock drivers themselves, we need >> > to select a proper implementation of the clock API, which for the meson, is >> > CCF >> >> Applied, thanks! >> >> [1/1] arm64: meson: select COMMON_CLK >> commit: aea7a80ad5effd48f44a7a08c3903168be038a43 >> >> Best regards, >> -- >> Kevin Hilman <khilman@baylibre.com> > > Why is this needed, and why would this make any difference? > COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in > arch/arm64/Kconfig selects it. Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had problem with COMMON_CLK (or any other clock implementation) being selected. TBH, I don't remember it exactly ... For sure this was a mistake. Neil, can you still drop it and do you need a revert ? > > Gr{oetje,eeting}s, > > Geert
Hi, On 08/06/2021 18:32, Jerome Brunet wrote: > > On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> Hi Jerome, >> >> On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: >>> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: >>>> This fix the recent removal of clock drivers selection. >>>> While it is not necessary to select the clock drivers themselves, we need >>>> to select a proper implementation of the clock API, which for the meson, is >>>> CCF >>> >>> Applied, thanks! >>> >>> [1/1] arm64: meson: select COMMON_CLK >>> commit: aea7a80ad5effd48f44a7a08c3903168be038a43 >>> >>> Best regards, >>> -- >>> Kevin Hilman <khilman@baylibre.com> >> >> Why is this needed, and why would this make any difference? >> COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in >> arch/arm64/Kconfig selects it. > > Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had > problem with COMMON_CLK (or any other clock implementation) being > selected. TBH, I don't remember it exactly ... > > For sure this was a mistake. > Neil, can you still drop it and do you need a revert ? I can't drop it, it has already been merged. Please send a revert and I'll push it for 5.14-rc fixes. Neil > >> >> Gr{oetje,eeting}s, >> >> Geert >
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index cdfd5fed457f..a3fdffcd1ce8 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -168,6 +168,7 @@ config ARCH_MEDIATEK config ARCH_MESON bool "Amlogic Platforms" + select COMMON_CLK select MESON_IRQ_GPIO help This enables support for the arm64 based Amlogic SoCs
This fix the recent removal of clock drivers selection. While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF Fixes: ba66a25536dd ("arm64: meson: ship only the necessary clock controllers") Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)