| Message ID | 20210608184940.25934-1-grygorii.strashko@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: k3-am642-main: fix ports mac properties | expand |
On 6/9/21 12:19 AM, Grygorii Strashko wrote: > The current device tree CPSW3g node adds non-zero "mac-address" property to > the ports, which prevents random MAC address assignment to network devices > if bootloader failed to update DT. This may cause more then one host to > have the same MAC in the network. > > mac-address = [00 00 de ad be ef]; > mac-address = [00 01 de ad be ef]; > > In addition, there is one MAC address available in eFuse registers which > can be used for default port 1. > > Hence, fix ports MAC properties by: > - resetting "mac-address" property to 0 > - adding ti,syscon-efuse = <&main_conf 0x200> to Port 1 > > Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node") > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com> > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index effb9d2e3c25..7f7178a7a055 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -514,7 +514,8 @@ > ti,mac-only; > label = "port1"; > phys = <&phy_gmii_sel 1>; > - mac-address = [00 00 de ad be ef]; > + mac-address = [00 00 00 00 00 00]; > + ti,syscon-efuse = <&main_conf 0x200>; > }; > > cpsw_port2: port@2 { > @@ -522,7 +523,7 @@ > ti,mac-only; > label = "port2"; > phys = <&phy_gmii_sel 2>; > - mac-address = [00 01 de ad be ef]; > + mac-address = [00 00 00 00 00 00]; > }; > }; > >
On Tue, 8 Jun 2021 21:49:40 +0300, Grygorii Strashko wrote: > The current device tree CPSW3g node adds non-zero "mac-address" property to > the ports, which prevents random MAC address assignment to network devices > if bootloader failed to update DT. This may cause more then one host to > have the same MAC in the network. > > mac-address = [00 00 de ad be ef]; > mac-address = [00 01 de ad be ef]; > > [...] Hi Grygorii Strashko, I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/1] arm64: dts: ti: k3-am642-main: fix ports mac properties commit: e04f89c15ea84967fae355d335c5df14349d038d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi index effb9d2e3c25..7f7178a7a055 100644 --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi @@ -514,7 +514,8 @@ ti,mac-only; label = "port1"; phys = <&phy_gmii_sel 1>; - mac-address = [00 00 de ad be ef]; + mac-address = [00 00 00 00 00 00]; + ti,syscon-efuse = <&main_conf 0x200>; }; cpsw_port2: port@2 { @@ -522,7 +523,7 @@ ti,mac-only; label = "port2"; phys = <&phy_gmii_sel 2>; - mac-address = [00 01 de ad be ef]; + mac-address = [00 00 00 00 00 00]; }; };
The current device tree CPSW3g node adds non-zero "mac-address" property to the ports, which prevents random MAC address assignment to network devices if bootloader failed to update DT. This may cause more then one host to have the same MAC in the network. mac-address = [00 00 de ad be ef]; mac-address = [00 01 de ad be ef]; In addition, there is one MAC address available in eFuse registers which can be used for default port 1. Hence, fix ports MAC properties by: - resetting "mac-address" property to 0 - adding ti,syscon-efuse = <&main_conf 0x200> to Port 1 Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node") Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)