| Message ID | 20210604194002.648037-1-Liam.Howlett@Oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/nommu: unexport do_munmap() | expand |
On Fri, Jun 04, 2021 at 07:40:16PM +0000, Liam Howlett wrote: > do_munmap() does not take the mmap_write_lock(). vm_munmap() should be > used instead. also, do_munmap was unexported for MMU builds back in 2012 by commit 17d1587f553d. Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com> > --- > mm/nommu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 0997ca38c2bd..3a93d4054810 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list > delete_vma(mm, vma); > return 0; > } > -EXPORT_SYMBOL(do_munmap); > > int vm_munmap(unsigned long addr, size_t len) > { > -- > 2.30.2 >
On 04.06.21 21:40, Liam Howlett wrote: > do_munmap() does not take the mmap_write_lock(). vm_munmap() should be > used instead. > > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com> > --- > mm/nommu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 0997ca38c2bd..3a93d4054810 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list > delete_vma(mm, vma); > return 0; > } > -EXPORT_SYMBOL(do_munmap); > > int vm_munmap(unsigned long addr, size_t len) > { > Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/mm/nommu.c b/mm/nommu.c index 0997ca38c2bd..3a93d4054810 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list delete_vma(mm, vma); return 0; } -EXPORT_SYMBOL(do_munmap); int vm_munmap(unsigned long addr, size_t len) {
do_munmap() does not take the mmap_write_lock(). vm_munmap() should be used instead. Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com> --- mm/nommu.c | 1 - 1 file changed, 1 deletion(-)