| Message ID | 20210609163717.3083-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | SoC identification support for RZ/G2L | expand |
Hi Prabhakar, On Wed, Jun 9, 2021 at 6:37 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add DT binding documentation for SYSC controller found on > RZ/G2{L,LC,UL} SoC's. > > SYSC block contains the LSI_DEVID register which is used to retrieve > SoC product information. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thanks for the update! > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/power/renesas,rzg2l-sysc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Renesas RZ/G2L System Controller (SYSC) > + > +maintainers: > + - Geert Uytterhoeven <geert+renesas@glider.be> > + > +description: > + The RZ/G2L System Controller (SYSC) performs system control of the LSI and > + supports following functions, > + - External terminal state capture function > + - 34-bit address space access function > + - Low power consumption control > + - WDT stop control > + > +properties: > + compatible: > + enum: > + - renesas,r9a07g044-sysc # RZ/G2{L,LC} > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: CA55/CM33 Sleep/Software Standby Mode request interrupt > + - description: CA55 Software Standby Mode release request interrupt > + - description: CM33 Software Standby Mode release request interrupt > + - description: CA55 ACE Asynchronous Bridge Master/Slave interface deny request interrupt > + > + interrupt-names: > + items: > + - const: sys_lpm_int > + - const: sys_ca55stbydone_int > + - const: sys_cm33stbyr_int > + - const: sys_ca55_deny The "sys_" prefixes feel superfluous to me. If you don't mind, I can remove them while applying (also from example and .dtsi). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Thu, Jun 10, 2021 at 1:22 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Jun 9, 2021 at 6:37 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add DT binding documentation for SYSC controller found on > > RZ/G2{L,LC,UL} SoC's. > > > > SYSC block contains the LSI_DEVID register which is used to retrieve > > SoC product information. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for the update! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml > > @@ -0,0 +1,63 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/power/renesas,rzg2l-sysc.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Renesas RZ/G2L System Controller (SYSC) > > + > > +maintainers: > > + - Geert Uytterhoeven <geert+renesas@glider.be> > > + > > +description: > > + The RZ/G2L System Controller (SYSC) performs system control of the LSI and > > + supports following functions, > > + - External terminal state capture function > > + - 34-bit address space access function > > + - Low power consumption control > > + - WDT stop control > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,r9a07g044-sysc # RZ/G2{L,LC} > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + items: > > + - description: CA55/CM33 Sleep/Software Standby Mode request interrupt > > + - description: CA55 Software Standby Mode release request interrupt > > + - description: CM33 Software Standby Mode release request interrupt > > + - description: CA55 ACE Asynchronous Bridge Master/Slave interface deny request interrupt > > + > > + interrupt-names: > > + items: > > + - const: sys_lpm_int > > + - const: sys_ca55stbydone_int > > + - const: sys_cm33stbyr_int > > + - const: sys_ca55_deny > > The "sys_" prefixes feel superfluous to me. > If you don't mind, I can remove them while applying (also from example > and .dtsi). > Fine with me, thank you for taking care of that. Cheers, Prabhakar
diff --git a/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml b/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml new file mode 100644 index 000000000000..49f95065a274 --- /dev/null +++ b/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/power/renesas,rzg2l-sysc.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Renesas RZ/G2L System Controller (SYSC) + +maintainers: + - Geert Uytterhoeven <geert+renesas@glider.be> + +description: + The RZ/G2L System Controller (SYSC) performs system control of the LSI and + supports following functions, + - External terminal state capture function + - 34-bit address space access function + - Low power consumption control + - WDT stop control + +properties: + compatible: + enum: + - renesas,r9a07g044-sysc # RZ/G2{L,LC} + + reg: + maxItems: 1 + + interrupts: + items: + - description: CA55/CM33 Sleep/Software Standby Mode request interrupt + - description: CA55 Software Standby Mode release request interrupt + - description: CM33 Software Standby Mode release request interrupt + - description: CA55 ACE Asynchronous Bridge Master/Slave interface deny request interrupt + + interrupt-names: + items: + - const: sys_lpm_int + - const: sys_ca55stbydone_int + - const: sys_cm33stbyr_int + - const: sys_ca55_deny + +required: + - compatible + - reg + - interrupts + - interrupt-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + // System Controller node + sysc: system-controller@11020000 { + compatible = "renesas,r9a07g044-sysc"; + reg = <0x11020000 0x10000>; + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "sys_lpm_int", "sys_ca55stbydone_int", + "sys_cm33stbyr_int", "sys_ca55_deny"; + };
Add DT binding documentation for SYSC controller found on RZ/G2{L,LC,UL} SoC's. SYSC block contains the LSI_DEVID register which is used to retrieve SoC product information. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- .../bindings/power/renesas,rzg2l-sysc.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml