mbox series

[v23,00/18] ARM Primecell PL35x support

Message ID 20210610082040.2075611-1-miquel.raynal@bootlin.com (mailing list archive)
Headers show
Series ARM Primecell PL35x support | expand

Message

Miquel Raynal June 10, 2021, 8:20 a.m. UTC
Hello,

I am taking over Naga's series, here are the major changes:
* Cleaning of the SMC bus binding file (and yaml conversion)
* Superficial cleaning and great simplification of the SMC bus driver
* Addition of a yaml file describing the NAND controller
* Full rework of the NAND controller driver. JFFS2 and UBIFS not tested
  yet, only bare test tools have been used to proove basic correctness
  of the helpers.
* Addition of a couple of MAINTAINERS entries.

A Github branch named pl353 is available on my repository:
https://github.com/miquelraynal/linux/

Thanks,
Miquèl

Changes in v23:
- Collected Naga Acked-by's.
- Used const instead of single enum entries in the bindings.
- Dropped the address-cells/size-cells superfluous definitions out of
  the NAND controller binding.
- Enhanced the SMC reg property description to mention that the various
  CS are described in the ranges property.
- Fixed the SMC child nodes regex to match Rob's requirements.

Changes in v22:
- Misc typo fixes.
- Light rewording of a few commit titles.
- Not forgetting to Cc: Rob and Krzysztof this time...

Changes in v21:
- Added Rob's Acked-by/Reviewed-by tags.
- Addressed all comments from Rob and Michael about the bindings.
- Tested both JFFS2 and UBIFS with simple file I/O.

Miquel Raynal (18):
  dt-binding: memory: pl353-smc: Rephrase the binding
  dt-binding: memory: pl353-smc: Document the range property
  dt-binding: memory: pl353-smc: Drop the partitioning section
  dt-binding: memory: pl353-smc: Describe the child reg property
  dt-binding: memory: pl353-smc: Fix the example syntax and style
  dt-binding: memory: pl353-smc: Drop unsupported nodes from the example
  dt-binding: memory: pl353-smc: Fix the NAND controller node in the
    example
  dt-binding: memory: pl353-smc: Enhance the description of the reg
    property
  dt-binding: memory: pl353-smc: Convert to yaml
  memory: pl353-smc: Fix style
  memory: pl353-smc: Rename goto labels
  memory: pl353-smc: Let lower level controller drivers handle inits
  memory: pl353-smc: Avoid useless acronyms in descriptions
  memory: pl353-smc: Declare variables following a reverse christmas
    tree order
  MAINTAINERS: Add PL353 SMC entry
  MAINTAINERS: Add PL353 NAND controller entry
  dt-bindings: mtd: pl353-nand: Describe this hardware controller
  mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller

 .../memory-controllers/arm,pl353-smc.yaml     |  131 ++
 .../bindings/memory-controllers/pl353-smc.txt |   47 -
 .../bindings/mtd/arm,pl353-nand-r2p1.yaml     |   53 +
 MAINTAINERS                                   |   16 +
 drivers/memory/pl353-smc.c                    |  314 +----
 drivers/mtd/nand/raw/Kconfig                  |    8 +
 drivers/mtd/nand/raw/Makefile                 |    1 +
 drivers/mtd/nand/raw/pl35x-nand-controller.c  | 1194 +++++++++++++++++
 include/linux/pl353-smc.h                     |   30 -
 9 files changed, 1413 insertions(+), 381 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml
 delete mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
 create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
 create mode 100644 drivers/mtd/nand/raw/pl35x-nand-controller.c
 delete mode 100644 include/linux/pl353-smc.h

Comments

Krzysztof Kozlowski June 10, 2021, 3:21 p.m. UTC | #1
On 10/06/2021 10:20, Miquel Raynal wrote:
> Hello,
> 
> I am taking over Naga's series, here are the major changes:
> * Cleaning of the SMC bus binding file (and yaml conversion)
> * Superficial cleaning and great simplification of the SMC bus driver
> * Addition of a yaml file describing the NAND controller
> * Full rework of the NAND controller driver. JFFS2 and UBIFS not tested
>   yet, only bare test tools have been used to proove basic correctness
>   of the helpers.
> * Addition of a couple of MAINTAINERS entries.
> 
> A Github branch named pl353 is available on my repository:
> https://github.com/miquelraynal/linux/
> 
> Thanks,
> Miquèl
> 
> Changes in v23:
> - Collected Naga Acked-by's.
> - Used const instead of single enum entries in the bindings.
> - Dropped the address-cells/size-cells superfluous definitions out of
>   the NAND controller binding.
> - Enhanced the SMC reg property description to mention that the various
>   CS are described in the ranges property.
> - Fixed the SMC child nodes regex to match Rob's requirements.
> 

I'll apply the memory patches here - dt-bindings which has Rob's ack and
driver changes. It's getting too late in the cycle and soon arm-soc
won't accept such big patchset.


Best regards,
Krzysztof
Krzysztof Kozlowski June 10, 2021, 3:24 p.m. UTC | #2
On Thu, 10 Jun 2021 10:20:22 +0200, Miquel Raynal wrote:
> I am taking over Naga's series, here are the major changes:
> * Cleaning of the SMC bus binding file (and yaml conversion)
> * Superficial cleaning and great simplification of the SMC bus driver
> * Addition of a yaml file describing the NAND controller
> * Full rework of the NAND controller driver. JFFS2 and UBIFS not tested
>   yet, only bare test tools have been used to proove basic correctness
>   of the helpers.
> * Addition of a couple of MAINTAINERS entries.
> 
> [...]

Applied, thanks!

[01/18] dt-binding: memory: pl353-smc: Rephrase the binding
        commit: a70eb9165e2a0f2867f0eb78f12665893d135ee1
[02/18] dt-binding: memory: pl353-smc: Document the range property
        commit: 386783ea6d9f21374cb11e0e8b8b4bd9770ef485
[03/18] dt-binding: memory: pl353-smc: Drop the partitioning section
        commit: f1d19f7400132b45cab4ee60e974150699fe28b5
[04/18] dt-binding: memory: pl353-smc: Describe the child reg property
        commit: 6c74a55e1d791be9758d9f23b1c5375854949188
[05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style
        commit: 540148ce3455f0dc4fac9414ac12337ae0ab7cf2
[06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example
        commit: 29c6d09f39591eb3ea5e8e64ed42b28b9ae31f99
[07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in the example
        commit: 9af22e1169dd6b0f498fa8f9bff7c44f721b1b20

8-9: still acks needed

[10/18] memory: pl353-smc: Fix style
        commit: 62584c870cba9c84f08dadc083c6359dc41df678
[11/18] memory: pl353-smc: Rename goto labels
        commit: edd84c4256e2a2c756a241728b8c31e14bbed2f7
[12/18] memory: pl353-smc: Let lower level controller drivers handle inits
        commit: 493db2b05d9217da5889840ee31121856627e3c6
[13/18] memory: pl353-smc: Avoid useless acronyms in descriptions
        commit: 9d7bb4493acfb7a131230e7785e7416de50b28b6
[14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order
        commit: df6c2646d0e459ea6aa1d2caff683cc75df63b31
[15/18] MAINTAINERS: Add PL353 SMC entry
        commit: 813d52799ad28579da3ed5a88c1bacd8069dd172

Best regards,
Krzysztof Kozlowski June 10, 2021, 9:09 p.m. UTC | #3
On Thu, 10 Jun 2021 10:20:22 +0200, Miquel Raynal wrote:
> I am taking over Naga's series, here are the major changes:
> * Cleaning of the SMC bus binding file (and yaml conversion)
> * Superficial cleaning and great simplification of the SMC bus driver
> * Addition of a yaml file describing the NAND controller
> * Full rework of the NAND controller driver. JFFS2 and UBIFS not tested
>   yet, only bare test tools have been used to proove basic correctness
>   of the helpers.
> * Addition of a couple of MAINTAINERS entries.
> 
> [...]

Applied, thanks!

[09/18] dt-binding: memory: pl353-smc: Convert to yaml
        commit: d3d0e1e857110a2f8147b1aa3a045b1fccc1e7c3

Best regards,