| Message ID | 20210610171553.3806-1-nramas@linux.microsoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' | expand |
On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian <nramas@linux.microsoft.com> wrote: > > The function prototype for ima_add_kexec_buffer() is present > in 'linux/ima.h'. But this header file is not included in > ima_kexec.c where the function is implemented. This results > in the following compiler warning when "-Wmissing-prototypes" flag > is turned on: > > security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype > for function 'ima_add_kexec_buffer' [-Wmissing-prototypes] > > Include the header file 'linux/ima.h' in ima_kexec.c to fix > the compiler warning. > > Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec) > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com> > --- > security/integrity/ima/ima_kexec.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org>
On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote: > The function prototype for ima_add_kexec_buffer() is present > in 'linux/ima.h'. But this header file is not included in > ima_kexec.c where the function is implemented. This results > in the following compiler warning when "-Wmissing-prototypes" flag > is turned on: > > security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype > for function 'ima_add_kexec_buffer' [-Wmissing-prototypes] > > Include the header file 'linux/ima.h' in ima_kexec.c to fix > the compiler warning. > > Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec) > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com> Thanks! Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux- integrity.git next-integrity-testing and next-integrity branches. Mimi
diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c index 667887665823..f799cc278a9a 100644 --- a/security/integrity/ima/ima_kexec.c +++ b/security/integrity/ima/ima_kexec.c @@ -11,6 +11,7 @@ #include <linux/vmalloc.h> #include <linux/kexec.h> #include <linux/of.h> +#include <linux/ima.h> #include "ima.h" #ifdef CONFIG_IMA_KEXEC
The function prototype for ima_add_kexec_buffer() is present in 'linux/ima.h'. But this header file is not included in ima_kexec.c where the function is implemented. This results in the following compiler warning when "-Wmissing-prototypes" flag is turned on: security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype for function 'ima_add_kexec_buffer' [-Wmissing-prototypes] Include the header file 'linux/ima.h' in ima_kexec.c to fix the compiler warning. Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec) Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com> --- security/integrity/ima/ima_kexec.c | 1 + 1 file changed, 1 insertion(+)