| Message ID | 20210610082040.2075611-18-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM Primecell PL35x support | expand |
On 10/06/2021 10:20, Miquel Raynal wrote: > Add a yaml description of this NAND controller which is described as a > subnode of the SMC bus. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../bindings/mtd/arm,pl353-nand-r2p1.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > new file mode 100644 > index 000000000000..5f126bb9b202 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PL353 NAND Controller device tree bindings > + > +allOf: > + - $ref: "nand-controller.yaml" > + > +maintainers: > + - Miquel Raynal <miquel.raynal@bootlin.com> > + - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> > + > +properties: > + compatible: > + items: I think you can skip the "items" here and leave only "const: foo". Best regards, Krzysztof
Hi Krzysztof, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote on Thu, 10 Jun 2021 10:48:16 +0200: > On 10/06/2021 10:20, Miquel Raynal wrote: > > Add a yaml description of this NAND controller which is described as a > > subnode of the SMC bus. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > .../bindings/mtd/arm,pl353-nand-r2p1.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > > > diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > new file mode 100644 > > index 000000000000..5f126bb9b202 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PL353 NAND Controller device tree bindings > > + > > +allOf: > > + - $ref: "nand-controller.yaml" > > + > > +maintainers: > > + - Miquel Raynal <miquel.raynal@bootlin.com> > > + - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> > > + > > +properties: > > + compatible: > > + items: > > I think you can skip the "items" here and leave only "const: foo". Crap, I missed that one, you're right. I'll wait a bit for Rob's feedback and eventually fix it when applying or resend (hopefully) only the NAND bits. Thanks, Miquèl
On Thu, Jun 10, 2021 at 10:56:53AM +0200, Miquel Raynal wrote: > Hi Krzysztof, > > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote on Thu, > 10 Jun 2021 10:48:16 +0200: > > > On 10/06/2021 10:20, Miquel Raynal wrote: > > > Add a yaml description of this NAND controller which is described as a > > > subnode of the SMC bus. > > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > --- > > > .../bindings/mtd/arm,pl353-nand-r2p1.yaml | 53 +++++++++++++++++++ > > > 1 file changed, 53 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > > new file mode 100644 > > > index 000000000000..5f126bb9b202 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > > > @@ -0,0 +1,53 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: PL353 NAND Controller device tree bindings > > > + > > > +allOf: > > > + - $ref: "nand-controller.yaml" > > > + > > > +maintainers: > > > + - Miquel Raynal <miquel.raynal@bootlin.com> > > > + - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> > > > + > > > +properties: > > > + compatible: > > > + items: > > > > I think you can skip the "items" here and leave only "const: foo". > > Crap, I missed that one, you're right. I'll wait a bit for Rob's > feedback and eventually fix it when applying or resend (hopefully) only > the NAND bits. Either way is fine.
On Thu, 10 Jun 2021 10:20:39 +0200, Miquel Raynal wrote: > Add a yaml description of this NAND controller which is described as a > subnode of the SMC bus. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../bindings/mtd/arm,pl353-nand-r2p1.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 2021-06-10 at 08:20:39 UTC, Miquel Raynal wrote: > Add a yaml description of this NAND controller which is described as a > subnode of the SMC bus. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Reviewed-by: Rob Herring <robh@kernel.org> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel
diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml new file mode 100644 index 000000000000..5f126bb9b202 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: PL353 NAND Controller device tree bindings + +allOf: + - $ref: "nand-controller.yaml" + +maintainers: + - Miquel Raynal <miquel.raynal@bootlin.com> + - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> + +properties: + compatible: + items: + - const: arm,pl353-nand-r2p1 + + reg: + items: + - items: + - description: CS with regard to the parent ranges property + - description: Offset of the memory region requested by the device + - description: Length of the memory region requested by the device + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + smcc: memory-controller@e000e000 { + compatible = "arm,pl353-smc-r2p1", "arm,primecell"; + reg = <0xe000e000 0x0001000>; + clock-names = "memclk", "apb_pclk"; + clocks = <&clkc 11>, <&clkc 44>; + ranges = <0x0 0x0 0xe1000000 0x1000000 /* Nand CS region */ + 0x1 0x0 0xe2000000 0x2000000 /* SRAM/NOR CS0 region */ + 0x2 0x0 0xe4000000 0x2000000>; /* SRAM/NOR CS1 region */ + #address-cells = <2>; + #size-cells = <1>; + + nfc0: nand-controller@0,0 { + compatible = "arm,pl353-nand-r2p1"; + reg = <0 0 0x1000000>; + #address-cells = <1>; + #size-cells = <0>; + }; + };
Add a yaml description of this NAND controller which is described as a subnode of the SMC bus. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- .../bindings/mtd/arm,pl353-nand-r2p1.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml