mbox series

[v4,0/3] Add watchdog for Mstar SoCs

Message ID 20210611200801.52139-1-romain.perier@gmail.com (mailing list archive)
Headers show
Series Add watchdog for Mstar SoCs | expand

Message

Romain Perier June 11, 2021, 8:07 p.m. UTC
This patches series adds a new driver for the watchdog found in the Mstar
MSC313e SoCs and newer. It adds a basic watchdog driver, the
corresponding devicetree bindings and its documentation.

This work has been co-developed with Daniel Palmer.

Changes since v3:
- Rebased onto v5.13-rc5
- Added Reviewed-by tags

Changes since v2:
- Renamed the dt-bindings documentation to mstar,msc313e-wdt.yaml
- Fixed the subject of the first commit
- Dropped unused dt labels

Changes since v1:
- Dropped "depends OF" from Kconfig (not required)
- Dropped unneeded include files
- Re-ordered include files
- Compute timeout_max dynamically from the probe function to avoid
  an overflow in _start().

Daniel Palmer (1):
  watchdog: Add Mstar MSC313e WDT driver

Romain Perier (2):
  dt-bindings: watchdog: Add Mstar MSC313e WDT devicetree bindings
    documentation
  ARM: dts: mstar: Add watchdog device_node definition

 .../bindings/watchdog/mstar,msc313e-wdt.yaml  |  40 +++++
 MAINTAINERS                                   |   1 +
 arch/arm/boot/dts/mstar-v7.dtsi               |  14 ++
 drivers/watchdog/Kconfig                      |  12 ++
 drivers/watchdog/Makefile                     |   1 +
 drivers/watchdog/msc313e_wdt.c                | 166 ++++++++++++++++++
 6 files changed, 234 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/mstar,msc313e-wdt.yaml
 create mode 100644 drivers/watchdog/msc313e_wdt.c

Comments

Guenter Roeck June 12, 2021, 12:59 p.m. UTC | #1
On Fri, Jun 11, 2021 at 10:07:58PM +0200, Romain Perier wrote:
> This patches series adds a new driver for the watchdog found in the Mstar
> MSC313e SoCs and newer. It adds a basic watchdog driver, the
> corresponding devicetree bindings and its documentation.
> 
> This work has been co-developed with Daniel Palmer.
> 
> Changes since v3:
> - Rebased onto v5.13-rc5
> - Added Reviewed-by tags

This works better. I applied patches 1 & 2 to my watchdog-next branch for
hand-off to Wim. Note that the arm dts patch needs to be pushed through the
arm tree.

Thanks,
Guenter

> 
> Changes since v2:
> - Renamed the dt-bindings documentation to mstar,msc313e-wdt.yaml
> - Fixed the subject of the first commit
> - Dropped unused dt labels
> 
> Changes since v1:
> - Dropped "depends OF" from Kconfig (not required)
> - Dropped unneeded include files
> - Re-ordered include files
> - Compute timeout_max dynamically from the probe function to avoid
>   an overflow in _start().
> 
> Daniel Palmer (1):
>   watchdog: Add Mstar MSC313e WDT driver
> 
> Romain Perier (2):
>   dt-bindings: watchdog: Add Mstar MSC313e WDT devicetree bindings
>     documentation
>   ARM: dts: mstar: Add watchdog device_node definition
> 
>  .../bindings/watchdog/mstar,msc313e-wdt.yaml  |  40 +++++
>  MAINTAINERS                                   |   1 +
>  arch/arm/boot/dts/mstar-v7.dtsi               |  14 ++
>  drivers/watchdog/Kconfig                      |  12 ++
>  drivers/watchdog/Makefile                     |   1 +
>  drivers/watchdog/msc313e_wdt.c                | 166 ++++++++++++++++++
>  6 files changed, 234 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/mstar,msc313e-wdt.yaml
>  create mode 100644 drivers/watchdog/msc313e_wdt.c
> 
> -- 
> 2.30.2
>
Daniel Palmer June 12, 2021, 5:10 p.m. UTC | #2
Hi Guenter, Romain,

On Sat, 12 Jun 2021 at 21:59, Guenter Roeck <linux@roeck-us.net> wrote:
> This works better. I applied patches 1 & 2 to my watchdog-next branch for
> hand-off to Wim. Note that the arm dts patch needs to be pushed through the
> arm tree.

I will take the dts patch and send a PR with it to the arm tree.

Cheers,

Daniel