| Message ID | CAFr9PXkMSDvks+DeCNJ6iKf6zDH0VaOL6msirR3g2K7BNL8YkQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Headers | show |
| Series | [GIT,PULL] ARM: mstar for v5.14 | expand |
Hi, On Sat, Jun 12, 2021 at 12:09:56PM +0900, Daniel Palmer wrote: > Hi Arnd, Olof, > > This is my first time doing this so apologies in advance if I've messed this up. > Anyhow, we have two very small patches for 5.14. Overall this is the right way to do it, but my tooling spotted a miss: You didn't sign off on at least one of the patches you applied (the UART one). Make sure you do 'git am -s' or similar so you have a S-o-b entry when you're the one applying the patch. Mind respinning the pull request with that corrected, so we avoid getting an email from Stephen Rothwell about it too? :) Beyond that, keeping an eye on how you sort patches when you have more material: In particular we keep DT, soc, drivers and defconfig updates in separate branches as much as we can -- sometimes dt-bindings need to be in both DT and driver branches, for example. That doesn't apply to this pull request, since the MAINTAINERS entry and the other one fix are fine to bundle (they would end up in the 'soc' branch at our end). We can tweak that over time as you get more familiar with how we separate the streams of patches. -Olof
Hi Olof, On Sun, 13 Jun 2021 at 01:15, Olof Johansson <olof@lixom.net> wrote: > Overall this is the right way to do it, but my tooling spotted a miss: You > didn't sign off on at least one of the patches you applied (the UART one). Make > sure you do 'git am -s' or similar so you have a S-o-b entry when you're the > one applying the patch. Ah, so there should have been a sign off from me for Romain's patch after the existing tags. > Mind respinning the pull request with that corrected, so we avoid getting an > email from Stephen Rothwell about it too? :) Sure. > Beyond that, keeping an eye on how you sort patches when you have more > material: In particular we keep DT, soc, drivers and defconfig updates in > separate branches as much as we can -- sometimes dt-bindings need to be in both > DT and driver branches, for example. That doesn't apply to this pull request, > since the MAINTAINERS entry and the other one fix are fine to bundle (they > would end up in the 'soc' branch at our end). Thanks for the heads up. We should have one DT patch for 5.14 that I'll send a separate pull request for. > We can tweak that over time as you get more familiar with how we separate > the streams of patches. Thanks! Cheers, Daniel
Hi Arnd, Olof, This is my first time doing this so apologies in advance if I've messed this up. Anyhow, we have two very small patches for 5.14. - Romain has stepped up to clean up some of the ~300 patch backlog for MStar and he added support for earlyprintk in the process. - In an effort to do things properly I've moved work on the MStar stuff from my personal github account to one for this project. So people can find it I've added a link in MAINTAINERS. The following changes since commit 614124bea77e452aa6df7a8714e8bc820b489922: Linux 5.13-rc5 (2021-06-06 15:47:27 -0700) are available in the Git repository at: https://github.com/linux-chenxing/linux.git tags/mstar-5.14 for you to fetch changes up to 06d09c789e2a78852adc99c54945457870247b09: MAINTAINERS: ARM/MStar/Sigmastar SoCs: Add a link to the MStar tree (2021-06-12 11:40:49 +0900) ---------------------------------------------------------------- Daniel Palmer (1): MAINTAINERS: ARM/MStar/Sigmastar SoCs: Add a link to the MStar tree Romain Perier (1): ARM: debug: add UART early console support for MSTAR SoCs MAINTAINERS | 1 + arch/arm/Kconfig.debug | 11 +++++++++++ 2 files changed, 12 insertions(+)