| Message ID | 20210614061512.3966143-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] fs: unexport __set_page_dirty | expand |
On Mon, Jun 14, 2021 at 08:15:10AM +0200, Christoph Hellwig wrote: > __set_page_dirty is only used by built-in code. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > fs/buffer.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Mon 14-06-21 08:15:10, Christoph Hellwig wrote: > __set_page_dirty is only used by built-in code. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/buffer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index ea48c01fb76b..3d18831c7ad8 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -611,7 +611,6 @@ void __set_page_dirty(struct page *page, struct address_space *mapping, > } > xa_unlock_irqrestore(&mapping->i_pages, flags); > } > -EXPORT_SYMBOL_GPL(__set_page_dirty); > > /* > * Add a page to the dirty page list. > -- > 2.30.2 >
On Mon, Jun 14, 2021 at 08:15:10AM +0200, Christoph Hellwig wrote: > __set_page_dirty is only used by built-in code. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> You might also want to do the equivalent of this: https://git.infradead.org/users/willy/pagecache.git/commitdiff/19b3bf0d1a51f41ce5450fdd863969c3d32dfe12
On Mon, Jun 14, 2021 at 01:32:42PM +0100, Matthew Wilcox wrote: > On Mon, Jun 14, 2021 at 08:15:10AM +0200, Christoph Hellwig wrote: > > __set_page_dirty is only used by built-in code. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > You might also want to do the equivalent of this: > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/19b3bf0d1a51f41ce5450fdd863969c3d32dfe12 This looks nice, but not really directly related. I think you should just send it to Andrew.
diff --git a/fs/buffer.c b/fs/buffer.c index ea48c01fb76b..3d18831c7ad8 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -611,7 +611,6 @@ void __set_page_dirty(struct page *page, struct address_space *mapping, } xa_unlock_irqrestore(&mapping->i_pages, flags); } -EXPORT_SYMBOL_GPL(__set_page_dirty); /* * Add a page to the dirty page list.
__set_page_dirty is only used by built-in code. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/buffer.c | 1 - 1 file changed, 1 deletion(-)