mbox series

[v2,0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

Message ID 20210608193605.2611114-1-venture@google.com (mailing list archive)
Headers show
Series Adds quanta-gbs-bmc machine to nuvoton boards. | expand

Message

Patrick Leis June 8, 2021, 7:36 p.m. UTC 
This is a board supported by OpenBmc.

v2:
- Fixed missing hyphen in Cortex name and dropped TODO on hardware
strap value.

Patrick Venture (2):
  hw/arm: add quanta-gbs-bmc machine
  hw/arm: quanta-gbs-bmc add i2c comments

 hw/arm/npcm7xx_boards.c | 93 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)

Comments

Peter Maydell June 14, 2021, 3:45 p.m. UTC | #1 
On Tue, 8 Jun 2021 at 20:36, Patrick Venture <venture@google.com> wrote:
>
> This is a board supported by OpenBmc.
>
> v2:
> - Fixed missing hyphen in Cortex name and dropped TODO on hardware
> strap value.
>
> Patrick Venture (2):
>   hw/arm: add quanta-gbs-bmc machine
>   hw/arm: quanta-gbs-bmc add i2c comments
>
>  hw/arm/npcm7xx_boards.c | 93 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)



Applied to target-arm.next, thanks.

-- PMM
Peter Maydell June 15, 2021, 3:45 p.m. UTC | #2 
On Tue, 8 Jun 2021 at 20:36, Patrick Venture <venture@google.com> wrote:
>
> This is a board supported by OpenBmc.
>
> v2:
> - Fixed missing hyphen in Cortex name and dropped TODO on hardware
> strap value.
>
> Patrick Venture (2):
>   hw/arm: add quanta-gbs-bmc machine
>   hw/arm: quanta-gbs-bmc add i2c comments

Forgot to ask for this earlier, but could you send a followup
patch that adds documentation for this new machine to
docs/system/arm/nuvoton.rst please ?

thanks
-- PMM
Patrick Leis June 15, 2021, 5:51 p.m. UTC | #3 
On Tue, Jun 15, 2021 at 8:46 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 8 Jun 2021 at 20:36, Patrick Venture <venture@google.com> wrote:
> >
> > This is a board supported by OpenBmc.
> >
> > v2:
> > - Fixed missing hyphen in Cortex name and dropped TODO on hardware
> > strap value.
> >
> > Patrick Venture (2):
> >   hw/arm: add quanta-gbs-bmc machine
> >   hw/arm: quanta-gbs-bmc add i2c comments
>
> Forgot to ask for this earlier, but could you send a followup
> patch that adds documentation for this new machine to
> docs/system/arm/nuvoton.rst please ?

Yeah, I'll try to get that this week.
Patrick

>
> thanks
> -- PMM