| Message ID | 20210615172159.2841877-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d0bbbf22b744153044a5e98c19df866dfbd18ea |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: mhi: Make symbol 'mhi_wwan_ops' static | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: jesse.brandeburg@intel.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 15 Jun 2021 17:21:59 +0000 you wrote: > The sparse tool complains as follows: > > drivers/net/mhi/net.c:385:23: warning: > symbol 'mhi_wwan_ops' was not declared. Should it be static? > > This symbol is not used outside of net.c, so marks it static. > > [...] Here is the summary with links: - [net-next] net: mhi: Make symbol 'mhi_wwan_ops' static https://git.kernel.org/netdev/net-next/c/1d0bbbf22b74 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c index 78d4a06fbeca..e5ec0d7510c8 100644 --- a/drivers/net/mhi/net.c +++ b/drivers/net/mhi/net.c @@ -382,7 +382,7 @@ static void mhi_net_dellink(void *ctxt, struct net_device *ndev, dev_set_drvdata(&mhi_dev->dev, NULL); } -const struct wwan_ops mhi_wwan_ops = { +static const struct wwan_ops mhi_wwan_ops = { .owner = THIS_MODULE, .priv_size = sizeof(struct mhi_net_dev), .setup = mhi_net_setup,
The sparse tool complains as follows: drivers/net/mhi/net.c:385:23: warning: symbol 'mhi_wwan_ops' was not declared. Should it be static? This symbol is not used outside of net.c, so marks it static. Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/mhi/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)