| Message ID | 20210615135724.29528-1-wanghai38@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 13 of 13 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, 15 Jun 2021 21:57:24 +0800 Wang Hai <wanghai38@huawei.com> wrote: > xdp_sample_pkts usage() is missing the introduction of the > "-S" option, this patch adds it. > > Signed-off-by: Wang Hai <wanghai38@huawei.com> > --- > samples/bpf/xdp_sample_pkts_user.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default") Acked-by: Jesper Dangaard Brouer <brouer@redhat.com> > diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c > index 706475e004cb..495e09897bd3 100644 > --- a/samples/bpf/xdp_sample_pkts_user.c > +++ b/samples/bpf/xdp_sample_pkts_user.c > @@ -103,7 +103,8 @@ static void usage(const char *prog) > fprintf(stderr, > "%s: %s [OPTS] <ifname|ifindex>\n\n" > "OPTS:\n" > - " -F force loading prog\n", > + " -F force loading prog\n" > + " -S use skb-mode\n", > __func__, prog); > } >
diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c index 706475e004cb..495e09897bd3 100644 --- a/samples/bpf/xdp_sample_pkts_user.c +++ b/samples/bpf/xdp_sample_pkts_user.c @@ -103,7 +103,8 @@ static void usage(const char *prog) fprintf(stderr, "%s: %s [OPTS] <ifname|ifindex>\n\n" "OPTS:\n" - " -F force loading prog\n", + " -F force loading prog\n" + " -S use skb-mode\n", __func__, prog); }
xdp_sample_pkts usage() is missing the introduction of the "-S" option, this patch adds it. Signed-off-by: Wang Hai <wanghai38@huawei.com> --- samples/bpf/xdp_sample_pkts_user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)