| Message ID | 20210616103649.2662395-3-jens.wiklander@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Asynchronous notifications from secure world | expand |
On Wed, 16 Jun 2021 12:36:44 +0200, Jens Wiklander wrote: > Converts the optee binding to use DT schema format. > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > --- > .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ------------ > .../arm/firmware/linaro,optee-tz.yaml | 49 +++++++++++++++++++ > 2 files changed, 49 insertions(+), 31 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml:21:7: [warning] wrong indentation: expected 4 but found 6 (indentation) dtschema/dtc warnings/errors: \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1492865 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Wed, Jun 16, 2021 at 12:36:44PM +0200, Jens Wiklander wrote: > Converts the optee binding to use DT schema format. > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > --- > .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ------------ > .../arm/firmware/linaro,optee-tz.yaml | 49 +++++++++++++++++++ > 2 files changed, 49 insertions(+), 31 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml Other than the indentation, Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Jun 16, 2021 at 6:05 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, Jun 16, 2021 at 12:36:44PM +0200, Jens Wiklander wrote: > > Converts the optee binding to use DT schema format. > > > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > > --- > > .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ------------ > > .../arm/firmware/linaro,optee-tz.yaml | 49 +++++++++++++++++++ > > 2 files changed, 49 insertions(+), 31 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > > create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > > Other than the indentation, > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks Rob. Nishanth reminded me of https://lore.kernel.org/linux-arm-kernel/20210503191327.GA2217487@robh.at.kernel.org/, aka be78329717e4 ("dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema") in linux-next. I'll wait for that one to land upstream instead. Cheers, Jens
diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt deleted file mode 100644 index d38834c67dff..000000000000 --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt +++ /dev/null @@ -1,31 +0,0 @@ -OP-TEE Device Tree Bindings - -OP-TEE is a piece of software using hardware features to provide a Trusted -Execution Environment. The security can be provided with ARM TrustZone, but -also by virtualization or a separate chip. - -We're using "linaro" as the first part of the compatible property for -the reference implementation maintained by Linaro. - -* OP-TEE based on ARM TrustZone required properties: - -- compatible : should contain "linaro,optee-tz" - -- method : The method of calling the OP-TEE Trusted OS. Permitted - values are: - - "smc" : SMC #0, with the register assignments specified - in drivers/tee/optee/optee_smc.h - - "hvc" : HVC #0, with the register assignments specified - in drivers/tee/optee/optee_smc.h - - - -Example: - firmware { - optee { - compatible = "linaro,optee-tz"; - method = "smc"; - }; - }; diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml new file mode 100644 index 000000000000..c931b030057f --- /dev/null +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/firmware/linaro,optee-tz.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OP-TEE Device Tree Bindings + +maintainers: + - Jens Wiklander <jens.wiklander@linaro.org> + +description: | + OP-TEE is a piece of software using hardware features to provide a Trusted + Execution Environment. The security can be provided with ARM TrustZone, but + also by virtualization or a separate chip. + +properties: + $nodename: + const: optee + compatible: + oneOf: + - description: + We're using "linaro" as the first part of the compatible property + for the reference implementation maintained by Linaro. + const: linaro,optee-tz + + method: + description: The method of calling the OP-TEE Trusted OS. + $ref: /schemas/types.yaml#/definitions/string-array + oneOf: + - description: | + SMC #0, with the register assignments specified in + in drivers/tee/optee/optee_smc.h + const: smc + - description: | + HVC #0, with the register assignments specified in + in drivers/tee/optee/optee_smc.h + const: hvc + +additionalProperties: false + +examples: + - | + firmware { + optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + };
Converts the optee binding to use DT schema format. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> --- .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ------------ .../arm/firmware/linaro,optee-tz.yaml | 49 +++++++++++++++++++ 2 files changed, 49 insertions(+), 31 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml