diff mbox series

[-next,2/4] ASoC: samsung: pcm: Use devm_platform_get_and_ioremap_resource()

Message ID 20210616091652.2552927-3-yangyingliang@huawei.com (mailing list archive)
State Accepted
Commit c3255553d6b6cd5c8de42d2faa80e1d33401cb3b
Headers show
Series ASoC: samsung: Use devm_platform_get_and_ioremap_resource() | expand

Commit Message

Yang Yingliang June 16, 2021, 9:16 a.m. UTC
Use devm_platform_get_and_ioremap_resource() to simplify
code.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/samsung/pcm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski June 21, 2021, 9:22 a.m. UTC | #1
On 16/06/2021 11:16, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  sound/soc/samsung/pcm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> index bfd76e9cc0ca..4c4dfde0568f 100644
> --- a/sound/soc/samsung/pcm.c
> +++ b/sound/soc/samsung/pcm.c
> @@ -512,8 +512,7 @@ static int s3c_pcm_dev_probe(struct platform_device *pdev)
>  	/* Default is 128fs */
>  	pcm->sclk_per_fs = 128;
>  
> -	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	pcm->regs = devm_ioremap_resource(&pdev->dev, mem_res);
> +	pcm->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
>  	if (IS_ERR(pcm->regs))
>  		return PTR_ERR(pcm->regs);
>  
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
index bfd76e9cc0ca..4c4dfde0568f 100644
--- a/sound/soc/samsung/pcm.c
+++ b/sound/soc/samsung/pcm.c
@@ -512,8 +512,7 @@  static int s3c_pcm_dev_probe(struct platform_device *pdev)
 	/* Default is 128fs */
 	pcm->sclk_per_fs = 128;
 
-	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	pcm->regs = devm_ioremap_resource(&pdev->dev, mem_res);
+	pcm->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
 	if (IS_ERR(pcm->regs))
 		return PTR_ERR(pcm->regs);