diff mbox

[3/4] pm34xx: Warning FIX related to ambiguous else loop

Message ID 1313754927-11992-4-git-send-email-abhilash.kv@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Koyamangalath, Abhilash Aug. 19, 2011, 11:55 a.m. UTC 
From: Vaibhav Hiremath <hvaibhav@ti.com>

Fixes below warning -

arch/arm/mach-omap2/pm34xx.c:1041: warning:
        suggest explicit braces to avoid ambiguous 'else

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
---
 arch/arm/mach-omap2/pm34xx.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Kevin Hilman Aug. 30, 2011, 11 p.m. UTC | #1 
Abhilash K V <abhilash.kv@ti.com> writes:

> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> Fixes below warning -
>
> arch/arm/mach-omap2/pm34xx.c:1041: warning:
>         suggest explicit braces to avoid ambiguous 'else

This warning was introduced in [1/4], so I'd suggest just folding this
fix into the original patch.

Kevin

> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
> ---
>  arch/arm/mach-omap2/pm34xx.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 12af5b9..ab3822b 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -856,7 +856,7 @@ void omap_push_sram_idle(void)
>  	else
>  		_omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend,
>  					omap34xx_cpu_suspend_sz);
> -	if (omap_type() != OMAP2_DEVICE_TYPE_GP)
> +	if (omap_type() != OMAP2_DEVICE_TYPE_GP) {
>  		if (cpu_is_omap3505() || cpu_is_omap3517())
>  			_omap_save_secure_sram = omap_sram_push(
>  					omap3517_save_secure_ram_context,
> @@ -865,6 +865,7 @@ void omap_push_sram_idle(void)
>  			_omap_save_secure_sram = omap_sram_push(
>  					save_secure_ram_context,
>  					save_secure_ram_context_sz);
> +	}
>  }
>  
>  static void __init pm_errata_configure(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 12af5b9..ab3822b 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -856,7 +856,7 @@  void omap_push_sram_idle(void)
 	else
 		_omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend,
 					omap34xx_cpu_suspend_sz);
-	if (omap_type() != OMAP2_DEVICE_TYPE_GP)
+	if (omap_type() != OMAP2_DEVICE_TYPE_GP) {
 		if (cpu_is_omap3505() || cpu_is_omap3517())
 			_omap_save_secure_sram = omap_sram_push(
 					omap3517_save_secure_ram_context,
@@ -865,6 +865,7 @@  void omap_push_sram_idle(void)
 			_omap_save_secure_sram = omap_sram_push(
 					save_secure_ram_context,
 					save_secure_ram_context_sz);
+	}
 }
 
 static void __init pm_errata_configure(void)