mbox series

[v2,0/2] xfs: fix buffer use after free on unpin abort

Message ID 20210621131644.128177-1-bfoster@redhat.com (mailing list archive)
Headers show
Series xfs: fix buffer use after free on unpin abort | expand

Message

Brian Foster June 21, 2021, 1:16 p.m. UTC 
v2:
- Split assert in patch 2.
v1: https://lore.kernel.org/linux-xfs/20210511135257.878743-1-bfoster@redhat.com/
- Rework patch 1 to hold conditionally in the abort case and document
  the underlying design flaw.
- Add patch 2 to remove some unused code.
rfc: https://lore.kernel.org/linux-xfs/20210503121816.561340-1-bfoster@redhat.com/

Brian Foster (2):
  xfs: hold buffer across unpin and potential shutdown processing
  xfs: remove dead stale buf unpin handling code

 fs/xfs/xfs_buf_item.c | 58 +++++++++++++++++--------------------------
 1 file changed, 23 insertions(+), 35 deletions(-)

Comments

Darrick J. Wong June 21, 2021, 4:57 p.m. UTC | #1 
On Mon, Jun 21, 2021 at 09:16:42AM -0400, Brian Foster wrote:
> v2:
> - Split assert in patch 2.
> v1: https://lore.kernel.org/linux-xfs/20210511135257.878743-1-bfoster@redhat.com/
> - Rework patch 1 to hold conditionally in the abort case and document
>   the underlying design flaw.
> - Add patch 2 to remove some unused code.
> rfc: https://lore.kernel.org/linux-xfs/20210503121816.561340-1-bfoster@redhat.com/
> 
> Brian Foster (2):
>   xfs: hold buffer across unpin and potential shutdown processing
>   xfs: remove dead stale buf unpin handling code

Doh, this totally fell off my radar.  Thanks for resubmitting it, I'll
put it in the test queue.

--D

> 
>  fs/xfs/xfs_buf_item.c | 58 +++++++++++++++++--------------------------
>  1 file changed, 23 insertions(+), 35 deletions(-)
> 
> -- 
> 2.26.3
>