| Message ID | 20210621093943.12143-8-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Mon, 21 Jun 2021 10:39:39 +0100, Biju Das wrote: > Renesas RZ/G2L SoC has USBPHY Control and USB2.0 PHY module. We need to > turn on both these phy modules before accessing host registers. > > Apart from this, document the optional property dr_mode present on both > RZ/G2 and R-Car Gen3 SoCs. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > .../devicetree/bindings/usb/generic-ehci.yaml | 33 +++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/generic-ehci.yaml:28:13: [warning] wrong indentation: expected 10 but found 12 (indentation) dtschema/dtc warnings/errors: \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1494982 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, I can reproduce the issue now, after installing 'yamllint' and using "DT_CHECKER_FLAGS=-m dt_binding_check". I will fix this and send v3. Regards, Biju > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 21 June 2021 18:40 > To: Biju Das <biju.das.jz@bp.renesas.com> > Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; > Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>; linux-renesas- > soc@vger.kernel.org; devicetree@vger.kernel.org; Geert Uytterhoeven > <geert+renesas@glider.be>; Rob Herring <robh+dt@kernel.org>; Greg Kroah- > Hartman <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; Chris > Paterson <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com> > Subject: Re: [PATCH v2 07/11] dt-bindings: usb: generic-ehci: Document > RZ/G2L SoC bindings > > On Mon, 21 Jun 2021 10:39:39 +0100, Biju Das wrote: > > Renesas RZ/G2L SoC has USBPHY Control and USB2.0 PHY module. We need > > to turn on both these phy modules before accessing host registers. > > > > Apart from this, document the optional property dr_mode present on > > both > > RZ/G2 and R-Car Gen3 SoCs. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > .../devicetree/bindings/usb/generic-ehci.yaml | 33 > > +++++++++++++++++-- > > 1 file changed, 31 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/usb/generic-ehci.yaml:28:13: [warning] > wrong indentation: expected 10 but found 12 (indentation) > > dtschema/dtc warnings/errors: > \ndoc reference errors (make refcheckdocs): > > See > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor > k.ozlabs.org%2Fpatch%2F1494982&data=04%7C01%7Cbiju.das.jz%40bp.renesas > .com%7Ca5c6e52f8fdc4596558e08d934dba5e6%7C53d82571da1947e49cb4625a166a4a2a > %7C0%7C0%7C637598940251415158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=A1oNbFJtcy > uOHvpE5IDBptxNhyoc5zlCVbPGpgnldIU%3D&reserved=0 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml index 8089dc956ba3..822e667e28a5 100644 --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml @@ -22,6 +22,27 @@ allOf: reg: maxItems: 1 + - if: + properties: + compatible: + contains: + const: renesas,r9a07g044-ehci + then: + properties: + phys: + maxItems: 2 + phy-names: + items: + - const: usbphyctrl + - const: usb + else: + properties: + phys: + maxItems: 1 + phy-names: + items: + - const: usb + properties: compatible: oneOf: @@ -57,6 +78,7 @@ properties: - ibm,476gtr-ehci - nxp,lpc1850-ehci - qca,ar7100-ehci + - renesas,r9a07g044-ehci - snps,hsdk-v1.0-ehci - socionext,uniphier-ehci - const: generic-ehci @@ -134,14 +156,21 @@ properties: Phandle of a companion. phys: - maxItems: 1 + minItems: 1 + maxItems: 2 phy-names: - const: usb + minItems: 1 + maxItems: 2 iommus: maxItems: 1 + dr_mode: + enum: + - host + - otg + required: - compatible - reg